linux-next: build warning after merge of the device-mapper tree

linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

Hi all,

After merging the device-mapper tree, today's linux-next build (powerp
ppc64_defconfig) produced this warning:

drivers/md/dm.c: In function '__send_changing_extent_only':
drivers/md/dm.c:1365:45: warning: 'ti' may be used uninitialized in this function [-Wmaybe-uninitialized]
  num_bios = get_num_bios ? get_num_bios(ti) : 0;
                                             ^

Introduced by commit

  aecefd4919de ("dm: fix __send_changing_extent_only() to send first bio and chain remainder")

This looks particularly bad :-(
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the device-mapper tree

[Mike Snitzer]

On Sun, Dec 10 2017 at  9:05pm -0500,
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the device-mapper tree, today's linux-next build (powerp
> ppc64_defconfig) produced this warning:
> 
> drivers/md/dm.c: In function '__send_changing_extent_only':
> drivers/md/dm.c:1365:45: warning: 'ti' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   num_bios = get_num_bios ? get_num_bios(ti) : 0;
>                                              ^
> 
> Introduced by commit
> 
>   aecefd4919de ("dm: fix __send_changing_extent_only() to send first bio and chain remainder")
> 
> This looks particularly bad :-(

I worked all weekend on DM code and compiled dm.c probably 30 times,
pretty bizarre that the RHEL7 gcc compiler isn't spewing anything about
this.

Anyway, I just fixed it via rebase (new commit is
6fb0326f0a19dd855bfd748481fd32035770376e).

Thanks,
Mike

Re: linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

Hi Mike,

On Mon, 11 Dec 2017 00:24:36 -0500 Mike Snitzer <snitzer@redhat.com> wrote:
>
> I worked all weekend on DM code and compiled dm.c probably 30 times,
> pretty bizarre that the RHEL7 gcc compiler isn't spewing anything about
> this.

That is weird.

> Anyway, I just fixed it via rebase (new commit is
> 6fb0326f0a19dd855bfd748481fd32035770376e).

Excellent, thanks.

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

Hi all,

After merging the device-mapper tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/md/dm-mpath.c: In function 'parse_path':
drivers/md/dm-mpath.c:891:24: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
  attached_handler_name = scsi_dh_attached_handler_name(q, GFP_KERNEL);
                        ^

Introduced by commit

  b8505ba97e0a ("dm mpath: fix attached_handler_name leak and dangling hw_handler_name pointer")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

Hi all,

After merging the device-mapper tree, today's linux-next build
(powerpc_ppc64_defconfig) produced this warning:

In file included from include/linux/blkdev.h:21,
                 from include/linux/blk-mq.h:5,
                 from drivers/md/dm-core.h:14,
                 from drivers/md/dm.c:8:
drivers/md/dm.c: In function 'dec_pending':
include/linux/bio.h:626:15: warning: 'bio' may be used uninitialized in this function [-Wmaybe-uninitialized]
  bio->bi_next = bl->head;
  ~~~~~~~~~~~~~^~~~~~~~~~
drivers/md/dm.c:930:14: note: 'bio' was declared here
  struct bio *bio;
              ^~~

Introduced by commit

  58c66b86cfe7 ("dm: improve noclone_endio() to support multipath target")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the device-mapper tree

[Mike Snitzer]

On Tue, Feb 19 2019 at  9:15pm -0500,
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi all,
> 
> After merging the device-mapper tree, today's linux-next build
> (powerpc_ppc64_defconfig) produced this warning:
> 
> In file included from include/linux/blkdev.h:21,
>                  from include/linux/blk-mq.h:5,
>                  from drivers/md/dm-core.h:14,
>                  from drivers/md/dm.c:8:
> drivers/md/dm.c: In function 'dec_pending':
> include/linux/bio.h:626:15: warning: 'bio' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   bio->bi_next = bl->head;
>   ~~~~~~~~~~~~~^~~~~~~~~~
> drivers/md/dm.c:930:14: note: 'bio' was declared here
>   struct bio *bio;
>               ^~~
> 
> Introduced by commit
> 
>   58c66b86cfe7 ("dm: improve noclone_endio() to support multipath target")

Thanks, I've fixed it up.

Mike

linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

Hi all,

After merging the device-mapper tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from drivers/md/dm-dust.c:11:
drivers/md/dm-dust.c: In function 'dust_list_badblocks':
drivers/md/dm-dust.c:307:10: warning: zero-length gnu_printf format string [-Wformat-zero-length]
  307 |   DMEMIT("");
      |          ^~
include/linux/device-mapper.h:555:46: note: in definition of macro 'DMEMIT'
  555 |      0 : scnprintf(result + sz, maxlen - sz, x))
      |                                              ^

Introduced by commit

  20f93ea74f9c ("dm dust: add interface to list all badblocks")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the device-mapper tree

[yangerkun]

在 2020/7/9 11:26, Stephen Rothwell 写道:
> Hi all,
> 
> After merging the device-mapper tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> In file included from drivers/md/dm-dust.c:11:
> drivers/md/dm-dust.c: In function 'dust_list_badblocks':
> drivers/md/dm-dust.c:307:10: warning: zero-length gnu_printf format string [-Wformat-zero-length]
>    307 |   DMEMIT("");
Mike and Bryan,

Should we just use "DMEMIT("\n")"? Maybe it's bad since this lead a
blank line...


>        |          ^~
> include/linux/device-mapper.h:555:46: note: in definition of macro 'DMEMIT'
>    555 |      0 : scnprintf(result + sz, maxlen - sz, x))
>        |                                              ^
> 
> Introduced by commit
> 
>    20f93ea74f9c ("dm dust: add interface to list all badblocks")
> 

linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

Hi all,

After merging the device-mapper tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/admin-guide/device-mapper/dm-integrity.rst:19
2: WARNING: Unexpected indentation.
Documentation/admin-guide/device-mapper/dm-integrity.rst:193: WARNING: Block quote ends without a blank line; unexpected unindent.

Introduced by commit

  61b8b2a834bf ("dm integrity: introduce the "fix_hmac" argument")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

Hi all,

After merging the device-mapper tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/admin-guide/device-mapper/dm-ima.rst:29: WARNING: Unexpected indentation.
Documentation/admin-guide/device-mapper/dm-ima.rst:52: WARNING: Definition list ends without a blank line; unexpected unindent.
Documentation/admin-guide/device-mapper/dm-ima.rst:109: WARNING: Unexpected indentation.
Documentation/admin-guide/device-mapper/dm-ima.rst:129: WARNING: Unexpected indentation.

Introduced by commit

  e820ba87f9d1 ("dm: add documentation for IMA measurement support")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

Hi all,

On Wed, 21 Jul 2021 17:34:32 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the device-mapper tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/admin-guide/device-mapper/dm-ima.rst:29: WARNING: Unexpected indentation.
> Documentation/admin-guide/device-mapper/dm-ima.rst:52: WARNING: Definition list ends without a blank line; unexpected unindent.
> Documentation/admin-guide/device-mapper/dm-ima.rst:109: WARNING: Unexpected indentation.
> Documentation/admin-guide/device-mapper/dm-ima.rst:129: WARNING: Unexpected indentation.
> 
> Introduced by commit
> 
>   e820ba87f9d1 ("dm: add documentation for IMA measurement support")

I am still getting these warnings.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

Hi all,

After merging the device-mapper tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/admin-guide/device-mapper/vdo.rst: WARNING: document isn't included in any toctree
Documentation/admin-guide/device-mapper/vdo-design.rst: WARNING: document isn't included in any toctree

Introduced by commit

  7903d6d10204 ("dm: add documentation for dm-vdo target")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

Hi all,

After merging the device-mapper tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/admin-guide/device-mapper/dm-crypt.rst:168: ERROR: Unexpected indentation.

Introduced by commit

  04a1020ad350 ("dm-crypt: limit the size of encryption requests")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the device-mapper tree

[Mikulas Patocka]

On Tue, 9 Jul 2024, Stephen Rothwell wrote:

> Hi all,
> 
> After merging the device-mapper tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/admin-guide/device-mapper/dm-crypt.rst:168: ERROR: Unexpected indentation.
> 
> Introduced by commit
> 
>   04a1020ad350 ("dm-crypt: limit the size of encryption requests")
> 
> -- 
> Cheers,
> Stephen Rothwell

How should it be fixed? Delete the '-' character? Or some other change?

Mikulas

Re: linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

Hi Mikulas,

On Tue, 9 Jul 2024 11:56:27 +0200 (CEST) Mikulas Patocka <mpatocka@redhat.com> wrote:
>
> On Tue, 9 Jul 2024, Stephen Rothwell wrote:
> 
> > After merging the device-mapper tree, today's linux-next build (htmldocs)
> > produced this warning:
> > 
> > Documentation/admin-guide/device-mapper/dm-crypt.rst:168: ERROR: Unexpected indentation.
> > 
> > Introduced by commit
> > 
> >   04a1020ad350 ("dm-crypt: limit the size of encryption requests")
> 
> How should it be fixed? Delete the '-' character? Or some other change?

Looking a few lines above shows indented paragraphs without the '-'
which seems to work.

-- 
Cheers
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the device-mapper tree

[Mikulas Patocka]

On Wed, 10 Jul 2024, Stephen Rothwell wrote:

> Hi Mikulas,
> 
> On Tue, 9 Jul 2024 11:56:27 +0200 (CEST) Mikulas Patocka <mpatocka@redhat.com> wrote:
> >
> > On Tue, 9 Jul 2024, Stephen Rothwell wrote:
> > 
> > > After merging the device-mapper tree, today's linux-next build (htmldocs)
> > > produced this warning:
> > > 
> > > Documentation/admin-guide/device-mapper/dm-crypt.rst:168: ERROR: Unexpected indentation.
> > > 
> > > Introduced by commit
> > > 
> > >   04a1020ad350 ("dm-crypt: limit the size of encryption requests")
> > 
> > How should it be fixed? Delete the '-' character? Or some other change?
> 
> Looking a few lines above shows indented paragraphs without the '-'
> which seems to work.

I hopefully fixed that.

Mikulas

Re: linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

Hi all,

On Wed, 10 Jul 2024 17:48:39 +0200 (CEST) Mikulas Patocka <mpatocka@redhat.com> wrote:
>
> On Wed, 10 Jul 2024, Stephen Rothwell wrote:
> 
> > On Tue, 9 Jul 2024 11:56:27 +0200 (CEST) Mikulas Patocka <mpatocka@redhat.com> wrote:  
> > >
> > > On Tue, 9 Jul 2024, Stephen Rothwell wrote:
> > >   
> > > > After merging the device-mapper tree, today's linux-next build (htmldocs)
> > > > produced this warning:
> > > > 
> > > > Documentation/admin-guide/device-mapper/dm-crypt.rst:168: ERROR: Unexpected indentation.
> > > > 
> > > > Introduced by commit
> > > > 
> > > >   04a1020ad350 ("dm-crypt: limit the size of encryption requests")  
> > > 
> > > How should it be fixed? Delete the '-' character? Or some other change?  
> > 
> > Looking a few lines above shows indented paragraphs without the '-'
> > which seems to work.  
> 
> I hopefully fixed that.

I am sill seeing this warning.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the device-mapper tree

[Mikulas Patocka]

On Tue, 30 Jul 2024, Stephen Rothwell wrote:

> Hi all,
> 
> On Wed, 10 Jul 2024 17:48:39 +0200 (CEST) Mikulas Patocka <mpatocka@redhat.com> wrote:
> >
> > On Wed, 10 Jul 2024, Stephen Rothwell wrote:
> > 
> > > On Tue, 9 Jul 2024 11:56:27 +0200 (CEST) Mikulas Patocka <mpatocka@redhat.com> wrote:  
> > > >
> > > > On Tue, 9 Jul 2024, Stephen Rothwell wrote:
> > > >   
> > > > > After merging the device-mapper tree, today's linux-next build (htmldocs)
> > > > > produced this warning:
> > > > > 
> > > > > Documentation/admin-guide/device-mapper/dm-crypt.rst:168: ERROR: Unexpected indentation.
> > > > > 
> > > > > Introduced by commit
> > > > > 
> > > > >   04a1020ad350 ("dm-crypt: limit the size of encryption requests")  
> > > > 
> > > > How should it be fixed? Delete the '-' character? Or some other change?  
> > > 
> > > Looking a few lines above shows indented paragraphs without the '-'
> > > which seems to work.  
> > 
> > I hopefully fixed that.
> 
> I am sill seeing this warning.

Hi

So, send a patch for it.

I don't know whats wrong with that documentation file.

Mikulas

Re: linux-next: build warning after merge of the device-mapper tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2150 bytes --]

Hi Mikulas,

On Tue, 30 Jul 2024 13:54:13 +0200 (CEST) Mikulas Patocka <mpatocka@redhat.com> wrote:
>
> On Tue, 30 Jul 2024, Stephen Rothwell wrote:
> 
> > On Wed, 10 Jul 2024 17:48:39 +0200 (CEST) Mikulas Patocka <mpatocka@redhat.com> wrote:  
> > >
> > > On Wed, 10 Jul 2024, Stephen Rothwell wrote:
> > >   
> > > > On Tue, 9 Jul 2024 11:56:27 +0200 (CEST) Mikulas Patocka <mpatocka@redhat.com> wrote:    
> > > > >
> > > > > On Tue, 9 Jul 2024, Stephen Rothwell wrote:
> > > > >     
> > > > > > After merging the device-mapper tree, today's linux-next build (htmldocs)
> > > > > > produced this warning:
> > > > > > 
> > > > > > Documentation/admin-guide/device-mapper/dm-crypt.rst:168: ERROR: Unexpected indentation.
> > > > > > 
> > > > > > Introduced by commit
> > > > > > 
> > > > > >   04a1020ad350 ("dm-crypt: limit the size of encryption requests")    
> > > > > 
> > > > > How should it be fixed? Delete the '-' character? Or some other change?    
> > > > 
> > > > Looking a few lines above shows indented paragraphs without the '-'
> > > > which seems to work.    
> > > 
> > > I hopefully fixed that.  
> > 
> > I am sill seeing this warning.  
> 
> So, send a patch for it.
> 
> I don't know whats wrong with that documentation file.

I am not sure either, but the following fixes it for me (but I don't
know if this produces the current output, sorry):

diff --git a/Documentation/admin-guide/device-mapper/dm-crypt.rst b/Documentation/admin-guide/device-mapper/dm-crypt.rst
index e625830d335e..08ff2df77be7 100644
--- a/Documentation/admin-guide/device-mapper/dm-crypt.rst
+++ b/Documentation/admin-guide/device-mapper/dm-crypt.rst
@@ -161,9 +161,9 @@ iv_large_sectors
    if this flag is specified.
 
 
-Module parameters::
-max_read_size
-max_write_size
+Module parameters:
+
+max_read_size max_write_size
    Maximum size of read or write requests. When a request larger than this size
    is received, dm-crypt will split the request. The splitting improves
    concurrency (the split requests could be encrypted in parallel by multiple

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]