From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>
Subject: linux-next: build failure after merge of the percpu tree
Date: Mon, 26 Feb 2018 14:57:56 +1100 [thread overview]
Message-ID: <20180226145756.228d1e23@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]
Hi all,
After merging the percpu tree, today's linux-next build (sparc defconfig)
failed like this:
mm/percpu.c: In function 'pcpu_balance_workfn':
mm/percpu.c:1613:3: error: implicit declaration of function 'cond_resched'; did you mean 'should_resched'? [-Werror=implicit-function-declaration]
cond_resched();
^~~~~~~~~~~~
should_resched
Caused by commit
accd4f36a7d1 ("percpu: add a schedule point in pcpu_balance_workfn()")
I have added this patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 26 Feb 2018 14:47:39 +1100
Subject: [PATCH] percpu: include sched.h for cond_resched()
Fixes: accd4f36a7d1 ("percpu: add a schedule point in pcpu_balance_workfn()")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
mm/percpu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/percpu.c b/mm/percpu.c
index 36e7b65ba6cf..15a398c00791 100644
--- a/mm/percpu.c
+++ b/mm/percpu.c
@@ -80,6 +80,7 @@
#include <linux/vmalloc.h>
#include <linux/workqueue.h>
#include <linux/kmemleak.h>
+#include <linux/sched.h>
#include <asm/cacheflush.h>
#include <asm/sections.h>
--
2.16.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2018-02-26 3:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 3:57 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-11 6:14 linux-next: build failure after merge of the percpu tree Stephen Rothwell
2023-12-11 8:31 ` Alexandre Ghiti
2023-12-11 19:25 ` Dennis Zhou
2014-08-27 4:22 Stephen Rothwell
2011-01-04 4:21 Stephen Rothwell
2011-01-04 5:13 ` Tejun Heo
2011-01-06 4:18 ` Stephen Rothwell
2011-01-06 5:11 ` Tejun Heo
2010-09-10 2:45 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226145756.228d1e23@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=cl@linux-foundation.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox