From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: linux-next: Signed-off-by missing for commit in the rdma-fixes tree Date: Thu, 8 Mar 2018 10:03:17 -0700 Message-ID: <20180308170317.GE6773@mellanox.com> References: <20180308164058.2ad5a158@canb.auug.org.au> <20180308161845.GC6773@mellanox.com> <1520527178.11634.9.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1520527178.11634.9.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org To: Joe Perches Cc: Stephen Rothwell , Andy Whitcroft , Doug Ledford , Linux-Next Mailing List , Linux Kernel Mailing List , Leon Romanovsky List-Id: linux-next.vger.kernel.org On Thu, Mar 08, 2018 at 08:39:38AM -0800, Joe Perches wrote: > On Thu, 2018-03-08 at 09:18 -0700, Jason Gunthorpe wrote: > > On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > Commit > > > > > > aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ") > > > > > > is missing a Signed-off-by from its author. > > > > Thanks Stephen, > > > > May I suggest to the checkpatch maintainers that checkpack should look > > for this too? > > No such commit in current -hext > $ git status HEAD > HEAD detached at next-20180308 https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=for-rc&id=aa0de36a40f446f5a21a7c1e677b98206e242edb > checkpatch doesn't try to match email sender to sign-off > as the email sender doesn't have to sign-off on a patch. > > It currently does: > > if ($is_patch && $has_commit_log && $chk_signoff && $signoff == 0) { > ERROR("MISSING_SIGN_OFF", > "Missing Signed-off-by: line(s)\n"); > } If I were to suggest an exact check it would be that the commit git author and commit git commiter both have signed-off-by lines, as I can't think of any cases where it would be appropriate for them to be missing? Jason