From: Gerd Hoffmann <kraxel@redhat.com>
To: alex.williamson@redhat.com
Cc: "open list:VFIO MEDIATED DEVICE DRIVERS" <kvm@vger.kernel.org>,
airlied@linux.ie, daniel.vetter@ffwll.ch,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Kirti Wankhede <kwankhede@nvidia.com>,
linux-next@vger.kernel.org, Gerd Hoffmann <kraxel@redhat.com>,
christian.koenig@amd.com
Subject: [PATCH 2/2] sample/mdev/mbochs: add mbochs_kunmap_dmabuf
Date: Mon, 25 Jun 2018 08:44:52 +0200 [thread overview]
Message-ID: <20180625064453.19768-2-kraxel@redhat.com> (raw)
In-Reply-To: <20180625064453.19768-1-kraxel@redhat.com>
There is no default implementation for dma_buf_ops->unmap.
So add a function unmapping the page, otherwise we'll leak them.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
samples/vfio-mdev/mbochs.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c
index aa25cda21d..85ac603769 100644
--- a/samples/vfio-mdev/mbochs.c
+++ b/samples/vfio-mdev/mbochs.c
@@ -811,11 +811,18 @@ static void *mbochs_kmap_dmabuf(struct dma_buf *buf, unsigned long page_num)
return kmap(page);
}
+static void mbochs_kunmap_dmabuf(struct dma_buf *buf, unsigned long page_num,
+ void *vaddr)
+{
+ kunmap(vaddr);
+}
+
static struct dma_buf_ops mbochs_dmabuf_ops = {
.map_dma_buf = mbochs_map_dmabuf,
.unmap_dma_buf = mbochs_unmap_dmabuf,
.release = mbochs_release_dmabuf,
.map = mbochs_kmap_dmabuf,
+ .unmap = mbochs_kunmap_dmabuf,
.mmap = mbochs_mmap_dmabuf,
};
--
2.9.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-06-25 6:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 6:44 [PATCH 1/2] sample/mdev/mbochs: remove mbochs_kmap_atomic_dmabuf Gerd Hoffmann
2018-06-25 6:44 ` Gerd Hoffmann [this message]
2018-06-26 7:20 ` [PATCH 2/2] sample/mdev/mbochs: add mbochs_kunmap_dmabuf Alex Williamson
2018-06-26 7:32 ` Gerd Hoffmann
2018-06-27 1:55 ` Alex Williamson
2018-06-25 15:43 ` [PATCH 1/2] sample/mdev/mbochs: remove mbochs_kmap_atomic_dmabuf Koenig, Christian
2018-06-26 7:16 ` Alex Williamson
-- strict thread matches above, loose matches on Subject: below --
2018-06-26 7:33 [PATCH 2/2] sample/mdev/mbochs: add mbochs_kunmap_dmabuf Koenig, Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625064453.19768-2-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox