Re: linux-next: build failure after merge of the xarray tree

Matthew Wilcox
2019-02-13T21:26:23Z

On Tue, Feb 12, 2019 at 04:23:31PM +0000, Jason Gunthorpe wrote:
> On Tue, Feb 12, 2019 at 08:15:28AM -0800, Matthew Wilcox wrote:
> > Seriously, there are several defects in the published API which do
> > warrant a change. The most severe one is that it's really easy to
> > forget to initialise the start index. And while I'm making that change,
> > I should fix smaller things like the errno at the same time.
>
> I hope you will send your tree in the 2nd week of the merge window
> with all these merge fixes in it..
>
> I think Linus will not like it if he has to fix this when merging
> rdma.

Ahhahhahhah. No. Burned once. Not doing that again.

https://lore.kernel.org/lkml/CA+55aFxFjAmrFpwQmEHCthHOzgidCKnod+cNDEE+3Spu9o1s3w@mail.gmail.com/

> > @@ -750,7 +738,7 @@ int ib_register_device(struct ib_device *device, const char *name)
> > int ret;
> >
> > ret = assign_name(device, name);
> > - if (ret)
> > + if (ret < 0)
> > return ret;
>
> This <0 should be near the xa_alloc_cyclic, I don't want the unusual
> '1' to propogate.. Far too likely that someone will forget about
> the special case.

Feel free to propose an alternate fix for sfr to put in his tree and we
can both include it as a proposed patch in our respective pull requests.