From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Subject: Re: linux-next: build warning after merge of the printk tree Date: Tue, 10 Jul 2018 22:15:47 +0900 Message-ID: <20180710131547.GA526@tigerII.localdomain> References: <20180710164514.22c552db@canb.auug.org.au> <2014348883.271177.1531206974788.JavaMail.jboss@ep1ml503> <20180710091909.rwgtahcew6grhd6n@pathway.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20180710091909.rwgtahcew6grhd6n@pathway.suse.cz> Sender: linux-kernel-owner@vger.kernel.org To: Petr Mladek Cc: Maninder Singh , Stephen Rothwell , Linux-Next Mailing List , Linux Kernel Mailing List , Vaneet Narang , PANKAJ MISHRA List-Id: linux-next.vger.kernel.org On (07/10/18 11:19), Petr Mladek wrote: > suppress_message_printing() is not longer called in console_unlock(). > Therefore it is not longer needed with disabled CONFIG_PRINTK. > > This fixes the warning: > > kernel/printk/printk.c:2033:13: warning: ‘suppress_message_printing’ defined but not used [-Wunused-function] > static bool suppress_message_printing(int level) { return false; } > > Reported-by: Stephen Rothwell > Suggested-by: Maninder Singh > Signed-off-by: Petr Mladek Acked-by: Sergey Senozhatsky Happens all the time to me as well. I'd rather remove CONFIG_PRINTK at this point ;) -ss