linux-next: Signed-off-by missing for commits in the pinctrl tree

linux-next: Signed-off-by missing for commits in the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

Hi Linus,

Commits

  bc319333c156 ("pinctrl: sh-pfc: r8a77965: Add HSCIF pins, groups, and functions")
  99500c6a4836 ("pinctrl: sh-pfc: r8a77990: Revise USB ID pin name")
  3d3c62d3458a ("pinctrl: sh-pfc: r8a77990: Add USB2.0 pins, groups and functions")
  1e0f13198edf ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the pinctrl tree

[Linus Walleij]

On Mon, Jul 16, 2018 at 12:10 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

>   bc319333c156 ("pinctrl: sh-pfc: r8a77965: Add HSCIF pins, groups, and functions")
>   99500c6a4836 ("pinctrl: sh-pfc: r8a77990: Revise USB ID pin name")
>   3d3c62d3458a ("pinctrl: sh-pfc: r8a77990: Add USB2.0 pins, groups and functions")
>   1e0f13198edf ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")
>
> are missing a Signed-off-by from their committer.

Oh initially it was just one of them, I rebased and fixed the one I thought
was the offender.

Oh well. I go back and fix all.

Yours,
Linus Walleij

Re: linux-next: Signed-off-by missing for commits in the pinctrl tree

[Linus Walleij]

On Mon, Jul 16, 2018 at 12:10 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Commits
>
>   bc319333c156 ("pinctrl: sh-pfc: r8a77965: Add HSCIF pins, groups, and functions")
>   99500c6a4836 ("pinctrl: sh-pfc: r8a77990: Revise USB ID pin name")
>   3d3c62d3458a ("pinctrl: sh-pfc: r8a77990: Add USB2.0 pins, groups and functions")
>   1e0f13198edf ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")
>
> are missing a Signed-off-by from their committer.

I am looking at this and I just feel confused. Top to bottom:

commit bc319333c156a710891942d34560b9fca0f52f5d
Author: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Date:   Thu Dec 14 13:04:55 2017 +0900

    pinctrl: sh-pfc: r8a77965: Add HSCIF pins, groups, and functions

    This patch adds HSCIF{0,1,2,3,4} pins, groups and functions to
    the R8A77965 SoC.

    Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

commit 99500c6a48360ebc9083c690add888c17afed519
Author: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Date:   Wed Jun 6 15:43:04 2018 +0900

    pinctrl: sh-pfc: r8a77990: Revise USB ID pin name

    Since the datasheet Rev.1.00 has an error about the USB ID pin name,
    this patch revises it.

    Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

commit 3d3c62d3458aef24f819834791c364c9f86146c7
Author: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Date:   Wed Jun 6 15:43:05 2018 +0900

    pinctrl: sh-pfc: r8a77990: Add USB2.0 pins, groups and functions

    This patch adds USB0_{PWEN,OVC}_{A,B} and USB0_ID pins, groups and
    functions to the R8A77990 SoC.

    Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
    Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

commit 1e0f13198edf47d0df1a8c0561eaeb525eac2154
Author: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Date:   Tue Jul 3 19:53:28 2018 +0900

    pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions

    This patch adds USB30_{PWEN,OVC} and USB3HS0_ID pins, groups and functions
    to the R8A77990 SoC.

    Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
    Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

This is very confusing, it looks correct to me.

As usual it must be some minor syntactic thing like a character missing or
something, I am just soo.... what's wrong here, really?

Yours,
Linus Walleij

Re: linux-next: Signed-off-by missing for commits in the pinctrl tree

[Geert Uytterhoeven]

Hi Linus,

On Mon, Jul 16, 2018 at 9:52 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Jul 16, 2018 at 12:10 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Commits
> >
> >   bc319333c156 ("pinctrl: sh-pfc: r8a77965: Add HSCIF pins, groups, and functions")
> >   99500c6a4836 ("pinctrl: sh-pfc: r8a77990: Revise USB ID pin name")
> >   3d3c62d3458a ("pinctrl: sh-pfc: r8a77990: Add USB2.0 pins, groups and functions")
> >   1e0f13198edf ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")
> >
> > are missing a Signed-off-by from their committer.
>
> I am looking at this and I just feel confused. Top to bottom:

> commit bc319333c156a710891942d34560b9fca0f52f5d
> Author: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Date:   Thu Dec 14 13:04:55 2017 +0900
>
>     pinctrl: sh-pfc: r8a77965: Add HSCIF pins, groups, and functions
>
>     This patch adds HSCIF{0,1,2,3,4} pins, groups and functions to
>     the R8A77965 SoC.
>
>     Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>     Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> This is very confusing, it looks correct to me.
>
> As usual it must be some minor syntactic thing like a character missing or
> something, I am just soo.... what's wrong here, really?

The previous issue was a missing commit from the _author_, not committer.
As you rebased the branch, _you_ are now the committer, not me anymore.
So now your SoBs must be present, too.

As I already told you I had fixed up the author SoB, and updated the tag,
just drop the above commits, pull sh-pfc-for-v4.19-tag1 again, and be done
with it ;-)

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: linux-next: Signed-off-by missing for commits in the pinctrl tree

[Linus Walleij]

On Mon, Jul 16, 2018 at 9:59 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> The previous issue was a missing commit from the _author_, not committer.
> As you rebased the branch, _you_ are now the committer, not me anymore.
> So now your SoBs must be present, too.

Yeah I figured. Sorry.

> As I already told you I had fixed up the author SoB, and updated the tag,
> just drop the above commits, pull sh-pfc-for-v4.19-tag1 again, and be done
> with it ;-)

But it's no fun if I can't do all mistakes myself! ;)

Yours,
Linus Walleij

Re: linux-next: Signed-off-by missing for commits in the pinctrl tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]

Hi Linus,

On Mon, 16 Jul 2018 09:52:44 +0200 Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Mon, Jul 16, 2018 at 12:10 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
> > Commits
> >
> >   bc319333c156 ("pinctrl: sh-pfc: r8a77965: Add HSCIF pins, groups, and functions")
> >   99500c6a4836 ("pinctrl: sh-pfc: r8a77990: Revise USB ID pin name")
> >   3d3c62d3458a ("pinctrl: sh-pfc: r8a77990: Add USB2.0 pins, groups and functions")
> >   1e0f13198edf ("pinctrl: sh-pfc: r8a77990: Add USB3.0 pins, groups and functions")
> >
> > are missing a Signed-off-by from their committer.  
> 
> I am looking at this and I just feel confused. Top to bottom:
> 
  ...
> 
> This is very confusing, it looks correct to me.
> 
> As usual it must be some minor syntactic thing like a character missing or
> something, I am just soo.... what's wrong here, really?

In the tree I fetched this morning, those commits are all committed by
you, but you did not add a Signed-off-by to then.  This usually happens
when you rebase a branch/tree.

$ git show --pretty=full bc319333c156
Author: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Commit: Linus Walleij <linus.walleij@linaro.org>

    pinctrl: sh-pfc: r8a77965: Add HSCIF pins, groups, and functions
    
    This patch adds HSCIF{0,1,2,3,4} pins, groups and functions to
    the R8A77965 SoC.
    
    Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

...
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commits in the pinctrl tree

[Linus Walleij]

On Mon, Jul 16, 2018 at 10:29 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> In the tree I fetched this morning, those commits are all committed by
> you, but you did not add a Signed-off-by to then.  This usually happens
> when you rebase a branch/tree.

Ah sorry man. Mark Brown told me the same thing this morning in
conversation, and of course I need to sign them off as I am now on
the delivery path.

Sorry for the fuzz :(

Yours,
Linus Walleij