From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislaw Gruszka Subject: Re: [PATCH] mt76x0: build driver only as module Date: Fri, 3 Aug 2018 11:28:23 +0200 Message-ID: <20180803092822.GD10284@redhat.com> References: <20180803091401.GB10284@redhat.com> <87zhy36c4n.fsf@kamboji.qca.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87zhy36c4n.fsf@kamboji.qca.qualcomm.com> Sender: linux-kernel-owner@vger.kernel.org To: Kalle Valo Cc: Wireless , Stephen Rothwell , Linux-Next Mailing List , Linux Kernel Mailing List List-Id: linux-next.vger.kernel.org On Fri, Aug 03, 2018 at 12:19:20PM +0300, Kalle Valo wrote: > Stanislaw Gruszka writes: > > > There are various symbols that conflicts with mt7601u. > > Due to that kernel will not build with allyesconfig. > > For now limit the driver to be build only as module. > > > > Signed-off-by: Stanislaw Gruszka > > Thanks for the quick patch! > > > --- a/drivers/net/wireless/mediatek/mt76/Kconfig > > +++ b/drivers/net/wireless/mediatek/mt76/Kconfig > > @@ -11,7 +11,7 @@ config MT76x2_COMMON > > > > config MT76x0U > > tristate "MediaTek MT76x0U (USB) support" > > - depends on MAC80211 > > + depends on MAC80211 && m > > But this feels like an ugly hack to me. Isn't there a better way to fix > this? (I don't have time to investigate the error in detail right now.) Yes, rename symbols names. And I will do this, just wanted to provide quick fix for the problem. Moreover seems the same thing should be done for mt7601u to avoid build errors and perhaps with mt76 :-( So I'm going to rename functions. Regards Stanislaw