* [PATCH] mt76x0: build driver only as module
@ 2018-08-03 9:14 Stanislaw Gruszka
2018-08-03 9:19 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Stanislaw Gruszka @ 2018-08-03 9:14 UTC (permalink / raw)
To: Kalle Valo, Wireless, Stephen Rothwell
Cc: Linux-Next Mailing List, Linux Kernel Mailing List
There are various symbols that conflicts with mt7601u.
Due to that kernel will not build with allyesconfig.
For now limit the driver to be build only as module.
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
---
drivers/net/wireless/mediatek/mt76/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/Kconfig b/drivers/net/wireless/mediatek/mt76/Kconfig
index 850611ad347a..2f25af9a08df 100644
--- a/drivers/net/wireless/mediatek/mt76/Kconfig
+++ b/drivers/net/wireless/mediatek/mt76/Kconfig
@@ -11,7 +11,7 @@ config MT76x2_COMMON
config MT76x0U
tristate "MediaTek MT76x0U (USB) support"
- depends on MAC80211
+ depends on MAC80211 && m
depends on USB
help
This adds support for MT7610U-based wireless USB dongles.
--
2.7.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mt76x0: build driver only as module
2018-08-03 9:14 [PATCH] mt76x0: build driver only as module Stanislaw Gruszka
@ 2018-08-03 9:19 ` Kalle Valo
2018-08-03 9:28 ` Stanislaw Gruszka
0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2018-08-03 9:19 UTC (permalink / raw)
To: Stanislaw Gruszka
Cc: Wireless, Stephen Rothwell, Linux-Next Mailing List,
Linux Kernel Mailing List
Stanislaw Gruszka <sgruszka@redhat.com> writes:
> There are various symbols that conflicts with mt7601u.
> Due to that kernel will not build with allyesconfig.
> For now limit the driver to be build only as module.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Thanks for the quick patch!
> --- a/drivers/net/wireless/mediatek/mt76/Kconfig
> +++ b/drivers/net/wireless/mediatek/mt76/Kconfig
> @@ -11,7 +11,7 @@ config MT76x2_COMMON
>
> config MT76x0U
> tristate "MediaTek MT76x0U (USB) support"
> - depends on MAC80211
> + depends on MAC80211 && m
But this feels like an ugly hack to me. Isn't there a better way to fix
this? (I don't have time to investigate the error in detail right now.)
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mt76x0: build driver only as module
2018-08-03 9:19 ` Kalle Valo
@ 2018-08-03 9:28 ` Stanislaw Gruszka
2018-08-03 10:09 ` Stanislaw Gruszka
0 siblings, 1 reply; 5+ messages in thread
From: Stanislaw Gruszka @ 2018-08-03 9:28 UTC (permalink / raw)
To: Kalle Valo
Cc: Wireless, Stephen Rothwell, Linux-Next Mailing List,
Linux Kernel Mailing List
On Fri, Aug 03, 2018 at 12:19:20PM +0300, Kalle Valo wrote:
> Stanislaw Gruszka <sgruszka@redhat.com> writes:
>
> > There are various symbols that conflicts with mt7601u.
> > Due to that kernel will not build with allyesconfig.
> > For now limit the driver to be build only as module.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
>
> Thanks for the quick patch!
>
> > --- a/drivers/net/wireless/mediatek/mt76/Kconfig
> > +++ b/drivers/net/wireless/mediatek/mt76/Kconfig
> > @@ -11,7 +11,7 @@ config MT76x2_COMMON
> >
> > config MT76x0U
> > tristate "MediaTek MT76x0U (USB) support"
> > - depends on MAC80211
> > + depends on MAC80211 && m
>
> But this feels like an ugly hack to me. Isn't there a better way to fix
> this? (I don't have time to investigate the error in detail right now.)
Yes, rename symbols names. And I will do this, just wanted to provide
quick fix for the problem.
Moreover seems the same thing should be done for mt7601u to avoid build
errors and perhaps with mt76 :-(
So I'm going to rename functions.
Regards
Stanislaw
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mt76x0: build driver only as module
2018-08-03 9:28 ` Stanislaw Gruszka
@ 2018-08-03 10:09 ` Stanislaw Gruszka
[not found] ` <20180803100939.GE10284-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Stanislaw Gruszka @ 2018-08-03 10:09 UTC (permalink / raw)
To: Kalle Valo
Cc: Wireless, Stephen Rothwell, Linux-Next Mailing List,
Linux Kernel Mailing List
On Fri, Aug 03, 2018 at 11:28:22AM +0200, Stanislaw Gruszka wrote:
> > But this feels like an ugly hack to me. Isn't there a better way to fix
> > this? (I don't have time to investigate the error in detail right now.)
>
> Yes, rename symbols names. And I will do this, just wanted to provide
> quick fix for the problem.
>
> Moreover seems the same thing should be done for mt7601u to avoid build
> errors and perhaps with mt76 :-(
>
> So I'm going to rename functions.
I have the patches, I'm building kernel with allyesconfig now,
it will take a while ...
Stanislaw
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-03 10:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-03 9:14 [PATCH] mt76x0: build driver only as module Stanislaw Gruszka
2018-08-03 9:19 ` Kalle Valo
2018-08-03 9:28 ` Stanislaw Gruszka
2018-08-03 10:09 ` Stanislaw Gruszka
[not found] ` <20180803100939.GE10284-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-03 10:31 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).