linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Adam Borowski <kilobyte@angband.pl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warnings from Linus' tree
Date: Sun, 19 Aug 2018 22:53:56 -0400	[thread overview]
Message-ID: <20180820025356.GF19200@thunk.org> (raw)
In-Reply-To: <20180820013319.slygmbleia55evtl@angband.pl>

On Mon, Aug 20, 2018 at 03:33:19AM +0200, Adam Borowski wrote:
> Valid uses of strncpy() do exist (such as SCSI structs), but those deal with
> fixed-width fields.  Thus, gcc is right for warning for at least some of
> misuse of strncpy() for C strings.  The function wasn't designed for them.

The problem is that the kernel has a goodly share of fixed-width
fields.  The ext4 superblock is one of them.  strncpy() is the most
convenient function to do what is needed.  If it's a valid use, then
we need to have a way to get gcc to shut up about them.

	   	   	      	 - Ted

  reply	other threads:[~2018-08-20  2:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-19 22:13 linux-next: build warnings from Linus' tree Stephen Rothwell
2018-08-19 22:16 ` Stephen Rothwell
2018-08-19 22:40   ` Stephen Rothwell
2018-08-19 23:21 ` Linus Torvalds
2018-08-20  1:33   ` Adam Borowski
2018-08-20  2:53     ` Theodore Y. Ts'o [this message]
2018-08-20  0:02 ` Theodore Y. Ts'o
2018-08-20 17:47   ` Miguel Ojeda
  -- strict thread matches above, loose matches on Subject: below --
2019-08-29 21:59 Stephen Rothwell
2018-06-11 22:14 Stephen Rothwell
2018-11-14  4:54 ` Joel Stanley
2018-11-14 10:20   ` Michael Ellerman
2018-11-18 11:22     ` Alan Modra
2018-12-03 23:24       ` Joel Stanley
2010-10-28  0:27 Stephen Rothwell
2010-10-28  3:04 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180820025356.GF19200@thunk.org \
    --to=tytso@mit.edu \
    --cc=kilobyte@angband.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).