linux-next: build failure after merge of the tty tree

linux-next: build failure after merge of the tty tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

Hi Greg,

After merging the tty tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id'
 static const struct of_device_id at91_usart_mode_of_match[] = {
                                  ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/mfd/at91-usart.c:52:4: error: field name not in record or union initializer
  { .compatible = "atmel,at91rm9200-usart" },
    ^
drivers/mfd/at91-usart.c:52:4: note: (near initialization for 'at91_usart_mode_of_match')
drivers/mfd/at91-usart.c:53:4: error: field name not in record or union initializer
  { .compatible = "atmel,at91sam9260-usart" },
    ^
drivers/mfd/at91-usart.c:53:4: note: (near initialization for 'at91_usart_mode_of_match')
drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but not used [-Wunused-variable]
 static const struct of_device_id at91_usart_mode_of_match[] = {
                                  ^~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")

Forgot to include <linux/mod_devicetable.h>?

I used the version of the tty tree from next-20180910 for today.



-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the tty tree

[Greg KH]

On Tue, Sep 11, 2018 at 12:58:57PM +1000, Stephen Rothwell wrote:
> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id'
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>                                   ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/mfd/at91-usart.c:52:4: error: field name not in record or union initializer
>   { .compatible = "atmel,at91rm9200-usart" },
>     ^
> drivers/mfd/at91-usart.c:52:4: note: (near initialization for 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:53:4: error: field name not in record or union initializer
>   { .compatible = "atmel,at91sam9260-usart" },
>     ^
> drivers/mfd/at91-usart.c:53:4: note: (near initialization for 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but not used [-Wunused-variable]
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>                                   ^~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> 
> Forgot to include <linux/mod_devicetable.h>?
> 
> I used the version of the tty tree from next-20180910 for today.

Very odd, I just pulled in the "Immutable" branch from Lee here.

Lee, is there something I am missing to get this to build properly?

thanks,

greg k-h

Re: linux-next: build failure after merge of the tty tree

[Lee Jones]

On Tue, 11 Sep 2018, Stephen Rothwell wrote:

> Hi Greg,
> 
> After merging the tty tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id'
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>                                   ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/mfd/at91-usart.c:52:4: error: field name not in record or union initializer
>   { .compatible = "atmel,at91rm9200-usart" },
>     ^
> drivers/mfd/at91-usart.c:52:4: note: (near initialization for 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:53:4: error: field name not in record or union initializer
>   { .compatible = "atmel,at91sam9260-usart" },
>     ^
> drivers/mfd/at91-usart.c:53:4: note: (near initialization for 'at91_usart_mode_of_match')
> drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but not used [-Wunused-variable]
>  static const struct of_device_id at91_usart_mode_of_match[] = {
>                                   ^~~~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> 
> Forgot to include <linux/mod_devicetable.h>?

Looks like a missing Device Tree header <linux/of.h>.

Will chase this today and follow up with another PR.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build failure after merge of the tty tree

[Nicolas Ferre]

On 11/09/2018 at 10:25, Lee Jones wrote:
> On Tue, 11 Sep 2018, Stephen Rothwell wrote:
> 
>> Hi Greg,
>>
>> After merging the tty tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id'
>>   static const struct of_device_id at91_usart_mode_of_match[] = {
>>                                    ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mfd/at91-usart.c:52:4: error: field name not in record or union initializer
>>    { .compatible = "atmel,at91rm9200-usart" },
>>      ^
>> drivers/mfd/at91-usart.c:52:4: note: (near initialization for 'at91_usart_mode_of_match')
>> drivers/mfd/at91-usart.c:53:4: error: field name not in record or union initializer
>>    { .compatible = "atmel,at91sam9260-usart" },
>>      ^
>> drivers/mfd/at91-usart.c:53:4: note: (near initialization for 'at91_usart_mode_of_match')
>> drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but not used [-Wunused-variable]
>>   static const struct of_device_id at91_usart_mode_of_match[] = {
>>                                    ^~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Caused by commit
>>
>>    7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
>>
>> Forgot to include <linux/mod_devicetable.h>?
> 
> Looks like a missing Device Tree header <linux/of.h>.
> 
> Will chase this today and follow up with another PR.

Hi all,

Actually it is due to the missing of  <linux/mod_devicetable.h> as 
Stephen suggested. It is due to the patch ac3167257b9f ("headers: 
separate linux/mod_devicetable.h from linux/platform_device.h") merged 
in v4.19-rc1.

because linux/platform_device.h was included by linux/mfd/core.h that is 
present in this driver. This is why the issue was not identified beforehand.

I'm building a tiny patch to address this right now.

Thanks for your help. Best regards,
-- 
Nicolas Ferre

Re: linux-next: build failure after merge of the tty tree

[Lee Jones]

On Tue, 11 Sep 2018, Nicolas Ferre wrote:

> On 11/09/2018 at 10:25, Lee Jones wrote:
> > On Tue, 11 Sep 2018, Stephen Rothwell wrote:
> > 
> > > Hi Greg,
> > > 
> > > After merging the tty tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > > 
> > > drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type 'struct of_device_id'
> > >   static const struct of_device_id at91_usart_mode_of_match[] = {
> > >                                    ^~~~~~~~~~~~~~~~~~~~~~~~
> > > drivers/mfd/at91-usart.c:52:4: error: field name not in record or union initializer
> > >    { .compatible = "atmel,at91rm9200-usart" },
> > >      ^
> > > drivers/mfd/at91-usart.c:52:4: note: (near initialization for 'at91_usart_mode_of_match')
> > > drivers/mfd/at91-usart.c:53:4: error: field name not in record or union initializer
> > >    { .compatible = "atmel,at91sam9260-usart" },
> > >      ^
> > > drivers/mfd/at91-usart.c:53:4: note: (near initialization for 'at91_usart_mode_of_match')
> > > drivers/mfd/at91-usart.c:51:34: warning: 'at91_usart_mode_of_match' defined but not used [-Wunused-variable]
> > >   static const struct of_device_id at91_usart_mode_of_match[] = {
> > >                                    ^~~~~~~~~~~~~~~~~~~~~~~~
> > > 
> > > Caused by commit
> > > 
> > >    7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART")
> > > 
> > > Forgot to include <linux/mod_devicetable.h>?
> > 
> > Looks like a missing Device Tree header <linux/of.h>.
> > 
> > Will chase this today and follow up with another PR.
> 
> Hi all,
> 
> Actually it is due to the missing of  <linux/mod_devicetable.h> as Stephen
> suggested. It is due to the patch ac3167257b9f ("headers: separate
> linux/mod_devicetable.h from linux/platform_device.h") merged in v4.19-rc1.

Since this set uses Device Tree, it really should include the of.h.

This solves the issue reported above.

I will fix-up and re-send the pull-request.

> because linux/platform_device.h was included by linux/mfd/core.h that is
> present in this driver. This is why the issue was not identified beforehand.
> 
> I'm building a tiny patch to address this right now.
> 
> Thanks for your help. Best regards,

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: linux-next: build failure after merge of the tty tree

[Andy Shevchenko]

On Tue, Sep 11, 2018 at 11:43 AM Lee Jones <lee.jones@linaro.org> wrote:
> On Tue, 11 Sep 2018, Nicolas Ferre wrote:

> > Actually it is due to the missing of  <linux/mod_devicetable.h> as Stephen
> > suggested. It is due to the patch ac3167257b9f ("headers: separate
> > linux/mod_devicetable.h from linux/platform_device.h") merged in v4.19-rc1.
>
> Since this set uses Device Tree, it really should include the of.h.

I didn't remember the contents of the driver, but I would disagree on
a statement that
*using* of_device_id table implies necessity of linux/of.h inclusion.

>
> This solves the issue reported above.
>
> I will fix-up and re-send the pull-request.


-- 
With Best Regards,
Andy Shevchenko

[PATCH] mfd: at91-usart: fix missing mod_devicetable.h

[Nicolas Ferre]

Following the inclusion of the patch ac3167257b9f ("headers:
separate linux/mod_devicetable.h from linux/platform_device.h"), there is a
build issue:

drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type
'struct of_device_id'
  static const struct of_device_id at91_usart_mode_of_match[] = {

Before this patch, the definition was reached by its inclusion of
linux/mfd/core.h.

The build issue is solved by simply adding the mod_devicetable.h in this
driver.

Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Radu Pirea <radu_nicolae.pirea@upb.ro>
---
 drivers/mfd/at91-usart.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/at91-usart.c b/drivers/mfd/at91-usart.c
index a4b9929c156f..ad743b8ca6be 100644
--- a/drivers/mfd/at91-usart.c
+++ b/drivers/mfd/at91-usart.c
@@ -11,6 +11,7 @@
 #include <dt-bindings/mfd/at91-usart.h>
 
 #include <linux/module.h>
+#include <linux/mod_devicetable.h>
 #include <linux/mfd/core.h>
 #include <linux/property.h>
 
-- 
2.15.1

Re: [PATCH] mfd: at91-usart: fix missing mod_devicetable.h

[Greg KH]

On Tue, Sep 11, 2018 at 10:44:48AM +0200, Nicolas Ferre wrote:
> Following the inclusion of the patch ac3167257b9f ("headers:
> separate linux/mod_devicetable.h from linux/platform_device.h"), there is a
> build issue:
> 
> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type
> 'struct of_device_id'
>   static const struct of_device_id at91_usart_mode_of_match[] = {
> 
> Before this patch, the definition was reached by its inclusion of
> linux/mfd/core.h.
> 
> The build issue is solved by simply adding the mod_devicetable.h in this
> driver.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Radu Pirea <radu_nicolae.pirea@upb.ro>

You forgot a "reported-by" :(

I'll go add it...

Re: [PATCH] mfd: at91-usart: fix missing mod_devicetable.h

[Lee Jones]

On Tue, 11 Sep 2018, Nicolas Ferre wrote:

> Following the inclusion of the patch ac3167257b9f ("headers:
> separate linux/mod_devicetable.h from linux/platform_device.h"), there is a
> build issue:
> 
> drivers/mfd/at91-usart.c:51:34: error: array type has incomplete element type
> 'struct of_device_id'
>   static const struct of_device_id at91_usart_mode_of_match[] = {
> 
> Before this patch, the definition was reached by its inclusion of
> linux/mfd/core.h.
> 
> The build issue is solved by simply adding the mod_devicetable.h in this
> driver.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Radu Pirea <radu_nicolae.pirea@upb.ro>
> ---
>  drivers/mfd/at91-usart.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/at91-usart.c b/drivers/mfd/at91-usart.c
> index a4b9929c156f..ad743b8ca6be 100644
> --- a/drivers/mfd/at91-usart.c
> +++ b/drivers/mfd/at91-usart.c
> @@ -11,6 +11,7 @@
>  #include <dt-bindings/mfd/at91-usart.h>
>  
>  #include <linux/module.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/mfd/core.h>
>  #include <linux/property.h>

Since this driver is using Device Tree, it is more correct to simply
add <linux/of.h>, unless of course we are also going to remove
<linux/mod_devicetable.h> from <linux/of.h>.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel