From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dave Carroll <david.carroll@microsemi.com>,
Kees Cook <keescook@google.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: linux-next: build warning after merge of the scsi-mkp tree
Date: Thu, 20 Dec 2018 17:34:57 +1100 [thread overview]
Message-ID: <20181220173457.66c83c0f@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]
Hi all,
After merging the scsi-mkp tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/scsi/smartpqi/smartpqi_init.c: In function 'pqi_build_raid_path_request':
drivers/scsi/smartpqi/smartpqi_init.c:478:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
cdb_length = 0;
~~~~~~~~~~~^~~
drivers/scsi/smartpqi/smartpqi_init.c:479:2: note: here
case BMIC_IDENTIFY_CONTROLLER:
^~~~
drivers/scsi/smartpqi/smartpqi_init.c:487:14: warning: this statement may fall through [-Wimplicit-fallthrough=]
cdb_length = 0;
~~~~~~~~~~~^~~
drivers/scsi/smartpqi/smartpqi_init.c:488:2: note: here
case BMIC_WRITE_HOST_WELLNESS:
^~~~
Introduced by commit
171c28653a2d ("scsi: smartpqi: turn off lun data caching for ptraid")
This due to my use of -Wimplicit-fallthrough for Kees Cook. This is
new code. The warning can be suppressed by adding a comment like
/* fall through */
just above the following "case" or "default" to indicate that the
fallthrough is intended.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2018-12-20 6:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-20 6:34 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-08-28 3:13 linux-next: build warning after merge of the scsi-mkp tree Stephen Rothwell
2023-07-24 4:04 Stephen Rothwell
2023-07-26 2:13 ` Martin K. Petersen
2023-05-23 3:38 Stephen Rothwell
2023-05-23 6:38 ` Damien Le Moal
2023-05-23 7:49 ` Damien Le Moal
2021-10-18 20:41 Stephen Rothwell
2021-11-08 0:06 ` Stephen Rothwell
2021-11-08 14:36 ` James Bottomley
2020-03-02 2:35 Stephen Rothwell
2020-03-02 14:36 ` Brian King
2020-03-06 4:52 ` Stephen Rothwell
2020-03-06 15:30 ` Brian King
2018-10-12 5:10 Stephen Rothwell
2018-07-11 4:17 Stephen Rothwell
2018-07-12 4:30 ` Stephen Rothwell
2018-07-12 6:10 ` Hannes Reinecke
2017-09-26 4:09 Stephen Rothwell
2017-09-27 3:27 ` Stephen Rothwell
2017-08-24 5:57 Stephen Rothwell
2017-08-24 5:59 ` Stephen Rothwell
2016-11-14 5:16 Stephen Rothwell
2016-11-14 12:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220173457.66c83c0f@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=david.carroll@microsemi.com \
--cc=gustavo@embeddedor.com \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).