From: Borislav Petkov <bp@alien8.de>
To: Sinan Kaya <okaya@kernel.org>
Cc: linux-next@vger.kernel.org, linux-acpi@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>
Subject: Re: [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled
Date: Tue, 22 Jan 2019 13:54:41 +0100 [thread overview]
Message-ID: <20190122125440.GG26587@zn.tnic> (raw)
In-Reply-To: <20190121231958.28255-2-okaya@kernel.org>
On Mon, Jan 21, 2019 at 11:19:58PM +0000, Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly.
>
> PCI_LOCKLESS_CONFIG depends on PCI but this dependency has not been
> mentioned in the Kconfig.
>
> Add an explicit dependency here.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
> arch/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 568f339595ed..0519da6f8ee4 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -199,7 +199,7 @@ config X86
> select IRQ_FORCED_THREADING
> select NEED_SG_DMA_LENGTH
> select PCI_DOMAINS if PCI
> - select PCI_LOCKLESS_CONFIG
> + select PCI_LOCKLESS_CONFIG if PCI
> select PERF_EVENTS
> select RTC_LIB
> select RTC_MC146818_LIB
> --
AFAICT, this is not really fixing a random config build issue but only
correcting the dependency, right?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-01-22 12:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 23:19 [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470 Sinan Kaya
2019-01-21 23:19 ` [for next][PATCH 2/2] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled Sinan Kaya
2019-01-22 12:54 ` Borislav Petkov [this message]
2019-01-22 14:39 ` Sinan Kaya
2019-01-24 10:51 ` Rafael J. Wysocki
2019-01-24 17:42 ` Sinan Kaya
2019-01-24 10:51 ` [for next][PATCH 1/2] mfd: Fix unmet dependency warning for MFD_TPS68470 Rafael J. Wysocki
2019-01-24 17:43 ` Sinan Kaya
2019-01-28 7:21 ` Lee Jones
2019-01-30 23:55 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122125440.GG26587@zn.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=okaya@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).