From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Rothwell Subject: Re: linux-next: powerpc le qemu boot failure after merge of the akpm tree Date: Thu, 31 Jan 2019 17:06:29 +1100 Message-ID: <20190131170629.2cc20600@canb.auug.org.au> References: <20190131163854.307e17ab@canb.auug.org.au> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/2GKmvTs3kSHCJSIEpW/T/5r"; protocol="application/pgp-signature" Return-path: In-Reply-To: <20190131163854.307e17ab@canb.auug.org.au> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Morton Cc: Linux Next Mailing List , Linux Kernel Mailing List , Mike Rapoport , Michael Ellerman , Benjamin Herrenschmidt , PowerPC , Christophe Leroy List-Id: linux-next.vger.kernel.org --Sig_/2GKmvTs3kSHCJSIEpW/T/5r Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, On Thu, 31 Jan 2019 16:38:54 +1100 Stephen Rothwell = wrote: > > [I am guessing that is is something in Andrew's tree that has caused > this.] >=20 > My qemu boot of the powerpc pseries_le_defconfig config failed like this: >=20 > htab_hash_mask =3D 0x1ffff > ----------------------------------------------------- > numa: NODE_DATA [mem 0x7ffe7000-0x7ffebfff] > Kernel panic - not syncing: sparse_buffer_init: Failed to allocate 214748= 3648 bytes align=3D0x10000 nid=3D0 from=3Dfffffffffffffff > CPU: 0 PID: 0 Comm: swapper Not tainted 5.0.0-rc4 #2 > Call Trace: > [c00000000105bbd0] [c000000000b1345c] dump_stack+0xb0/0xf4 (unreliable) > [c00000000105bc10] [c000000000111120] panic+0x168/0x3b8 > [c00000000105bcb0] [c000000000e701c8] sparse_init_nid+0x178/0x550 > [c00000000105bd70] [c000000000e709b4] sparse_init+0x210/0x238 > [c00000000105bdb0] [c000000000e468f4] initmem_init+0x1e0/0x260 > [c00000000105be80] [c000000000e3b9b0] setup_arch+0x354/0x3d4 > [c00000000105bef0] [c000000000e33afc] start_kernel+0x98/0x648 > [c00000000105bf90] [c00000000000b270] start_here_common+0x1c/0x52c A quick bisect leads to this: 1c3c9328cde027eb875ba4692f0a5d66b0afe862 is the first bad commit commit 1c3c9328cde027eb875ba4692f0a5d66b0afe862 Author: Mike Rapoport Date: Thu Jan 31 10:51:32 2019 +1100 treewide: add checks for the return value of memblock_alloc*() =20 Add check for the return value of memblock_alloc*() functions and call panic() in case of error. The panic message repeats the one used by panicing memblock allocators with adjustment of parameters to include o= nly relevant ones. =20 The replacement was mostly automated with semantic patches like the one below with manual massaging of format strings. =20 @@ expression ptr, size, align; @@ ptr =3D memblock_alloc(size, align); + if (!ptr) + panic("%s: Failed to allocate %lu bytes align=3D0x%lx\n", __fun= c__, size, align); =20 Link: http://lkml.kernel.org/r/1548057848-15136-20-git-send-email-rppt@= linux.ibm.com Signed-off-by: Mike Rapoport Reviewed-by: Guo Ren [c-sky] Acked-by: Paul Burton [MIPS] Acked-by: Heiko Carstens [s390] Reviewed-by: Juergen Gross [Xen] Reviewed-by: Geert Uytterhoeven [m68k] Cc: Catalin Marinas Cc: Christophe Leroy Cc: Christoph Hellwig Cc: "David S. Miller" Cc: Dennis Zhou Cc: Greentime Hu Cc: Greg Kroah-Hartman Cc: Guan Xuetao Cc: Guo Ren Cc: Mark Salter Cc: Matt Turner Cc: Max Filippov Cc: Michael Ellerman Cc: Michal Simek Cc: Petr Mladek Cc: Richard Weinberger Cc: Rich Felker Cc: Rob Herring Cc: Rob Herring Cc: Russell King Cc: Stafford Horne Cc: Tony Luck Cc: Vineet Gupta Cc: Yoshinori Sato Signed-off-by: Andrew Morton Which is just adding the panic we hit. So, presumably, the bug is in a preceding patch :-( I have left the kernel not booting for today. --=20 Cheers, Stephen Rothwell --Sig_/2GKmvTs3kSHCJSIEpW/T/5r Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAlxSkGUACgkQAVBC80lX 0GwU8wf9Fn6s9XvjRxjoTKORPTSxJnh4Uga/d0Yx2h675XLTz5HGkpQ2IsUDehWM OebE2vxH54ND59Yfb3mgvld8FnGx83tiaw7zqLZtU60AkUE/O48czI4BIUhRFoeb uVkeAwmf7W+9eHhywrE+omGDvA6RcPNC8owH+1wSZiq3Rt6cVlFbAIYDpwAtXdFm SWyZBkJOpUQ2coIKKNXOZXpWCGN4QYlryRQtyQIu09bd5MaMJ2/ktbZj/ywnexbN 9Xot9aVWAlIRf1CM+EFBsu+k892e7iIvs19WQIyaKL80CApugq2F+r4auqDAkkQ1 Lu8IyCLcM2MicMXol9O18FDO2XIDBA== =f2TJ -----END PGP SIGNATURE----- --Sig_/2GKmvTs3kSHCJSIEpW/T/5r--