From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jens Axboe <axboe@kernel.dk>, David Sterba <dsterba@suse.cz>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Qu Wenruo <wqu@suse.com>, Ming Lei <ming.lei@redhat.com>
Subject: linux-next: manual merge of the block tree with the btrfs-kdave tree
Date: Mon, 18 Feb 2019 12:07:35 +1100 [thread overview]
Message-ID: <20190218120735.67e66a4f@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 2085 bytes --]
Hi Jens,
Today's linux-next merge of the block tree got a conflict in:
fs/btrfs/extent_io.c
between commit:
2ce8afc500de ("btrfs: extent_io: Kill the forward declaration of flush_write_bio")
from the btrfs-kdave tree and commit:
c3a7ce738009 ("btrfs: use mp_bvec_last_segment to get bio's last page")
from the block tree.
I fixed it up (the former moved the function updated by the latter - see
below) and can carry the fix as necessary. This is now fixed as far as
linux-next is concerned, but any non trivial conflicts should be mentioned
to your upstream maintainer when your tree is submitted for merging.
You may also want to consider cooperating with the maintainer of the
conflicting tree to minimise any particularly complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc fs/btrfs/extent_io.c
index ca259c75bbcd,4ed58c9a94a9..000000000000
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@@ -147,38 -147,7 +147,39 @@@ static int add_extent_changeset(struct
return ret;
}
-static void flush_write_bio(struct extent_page_data *epd);
+static int __must_check submit_one_bio(struct bio *bio, int mirror_num,
+ unsigned long bio_flags)
+{
+ blk_status_t ret = 0;
+ struct bio_vec *bvec = bio_last_bvec_all(bio);
- struct page *page = bvec->bv_page;
++ struct bio_vec bv;
+ struct extent_io_tree *tree = bio->bi_private;
+ u64 start;
+
- start = page_offset(page) + bvec->bv_offset;
++ mp_bvec_last_segment(bvec, &bv);
++ start = page_offset(bv.bv_page) + bv.bv_offset;
+
+ bio->bi_private = NULL;
+
+ if (tree->ops)
+ ret = tree->ops->submit_bio_hook(tree->private_data, bio,
+ mirror_num, bio_flags, start);
+ else
+ btrfsic_submit_bio(bio);
+
+ return blk_status_to_errno(ret);
+}
+
+static void flush_write_bio(struct extent_page_data *epd)
+{
+ if (epd->bio) {
+ int ret;
+
+ ret = submit_one_bio(epd->bio, 0, 0);
+ BUG_ON(ret < 0); /* -ENOMEM */
+ epd->bio = NULL;
+ }
+}
int __init extent_io_init(void)
{
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2019-02-18 1:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 1:07 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-21 3:13 linux-next: manual merge of the block tree with the btrfs-kdave tree Stephen Rothwell
2017-06-20 1:37 Stephen Rothwell
2017-06-13 3:50 Stephen Rothwell
2017-06-13 3:34 Stephen Rothwell
2017-06-13 3:27 Stephen Rothwell
2017-06-13 3:15 Stephen Rothwell
2016-11-17 2:01 Stephen Rothwell
2016-11-17 2:49 ` Jens Axboe
2016-11-17 13:23 ` Christoph Hellwig
2016-11-18 17:47 ` David Sterba
2016-07-08 4:03 Stephen Rothwell
2016-07-08 4:00 Stephen Rothwell
2016-07-08 3:49 Stephen Rothwell
2016-07-08 3:31 Stephen Rothwell
2016-07-08 3:27 Stephen Rothwell
2016-07-08 3:26 Stephen Rothwell
2016-06-24 2:34 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218120735.67e66a4f@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=axboe@kernel.dk \
--cc=dsterba@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).