Re: linux-next: Fixes tag needs some work in the net-next tree

Stefano Brivio
2019-02-20T20:37:29Z

On Wed, 20 Feb 2019 12:25:48 -0800 (PST)
David Miller <davem@davemloft.net> wrote:

> From: Stefano Brivio <sbrivio@redhat.com>
> Date: Wed, 20 Feb 2019 20:59:10 +0100
>
> > On Wed, 20 Feb 2019 11:02:01 -0800 (PST)
> > David Miller <davem@davemloft.net> wrote:
> >
> >> From: Jiri Pirko <jiri@resnulli.us>
> >> Date: Wed, 20 Feb 2019 09:36:11 +0100
> >>
> >> > Would be good to have some robot checking "Fixes" sanity...
> >>
> >> I want to add a script to my trees that locally do it for me but the
> >> backlog for patch review for me is so huge that I never get to "fun"
> >> tasks like that....
> >
> > If it helps, this is what I use after being bitten once:
>
> Awesome, thanks! You put this in as a pre-commit script?

Nope, I use it before sending patches out with git send-email.

But you can use this as .git/hooks/commit-msg, just skip taking the
tree as second argument, something like this (just quickly tested):

#!/bin/sh

grep "^Fixes: " "${1}" | while read -r f; do
sha="$(echo "${f}" | cut -d' ' -f2)"
if [ -z "${sha}" ] || [ "${f}" != "$(git show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null)" ]; then
echo "Bad tag: ${f}" && exit 1
fi
done

--
Stefano