From: Leon Romanovsky <leonro@mellanox.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Matthew Wilcox <willy@infradead.org>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@mellanox.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the xarray tree
Date: Thu, 21 Feb 2019 12:34:42 +0000 [thread overview]
Message-ID: <20190221123440.GD17501@mtr-leonro.mtl.com> (raw)
In-Reply-To: <20190221171332.262cf619@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 5405 bytes --]
On Thu, Feb 21, 2019 at 05:13:32PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the xarray tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from include/linux/uio.h:12,
> from include/linux/socket.h:8,
> from include/rdma/rdma_cm.h:37,
> from drivers/infiniband/core/restrack.c:6:
> drivers/infiniband/core/restrack.c: In function 'rt_xa_alloc_cyclic':
> include/linux/kernel.h:40:18: warning: passing argument 3 of '__xa_alloc' makes pointer from integer without a cast [-Wint-conversion]
> #define U32_MAX ((u32)~0U)
> ^~~~~~~~~~
> drivers/infiniband/core/restrack.c:26:27: note: in expansion of macro 'U32_MAX'
> err = __xa_alloc(xa, id, U32_MAX, entry, GFP_KERNEL);
> ^~~~~~~
> In file included from include/linux/radix-tree.h:31,
> from include/linux/fs.h:15,
> from include/linux/seq_file.h:11,
> from arch/powerpc/include/asm/machdep.h:12,
> from arch/powerpc/include/asm/archrandom.h:7,
> from include/linux/random.h:166,
> from include/linux/net.h:22,
> from include/linux/skbuff.h:29,
> from include/linux/if_arp.h:26,
> from include/rdma/ib_addr.h:39,
> from include/rdma/rdma_cm.h:39,
> from drivers/infiniband/core/restrack.c:6:
> include/linux/xarray.h:524:61: note: expected 'void *' but argument is of type 'unsigned int'
> int __must_check __xa_alloc(struct xarray *, u32 *id, void *entry,
> ~~~~~~^~~~~
> drivers/infiniband/core/restrack.c:26:36: error: incompatible type for argument 4 of '__xa_alloc'
> err = __xa_alloc(xa, id, U32_MAX, entry, GFP_KERNEL);
> ^~~~~
> In file included from include/linux/radix-tree.h:31,
> from include/linux/fs.h:15,
> from include/linux/seq_file.h:11,
> from arch/powerpc/include/asm/machdep.h:12,
> from arch/powerpc/include/asm/archrandom.h:7,
> from include/linux/random.h:166,
> from include/linux/net.h:22,
> from include/linux/skbuff.h:29,
> from include/linux/if_arp.h:26,
> from include/rdma/ib_addr.h:39,
> from include/rdma/rdma_cm.h:39,
> from drivers/infiniband/core/restrack.c:6:
> include/linux/xarray.h:525:3: note: expected 'struct xa_limit' but argument is of type 'void *'
> struct xa_limit, gfp_t);
> ^~~~~~~~~~~~~~~
> drivers/infiniband/core/restrack.c:29:28: warning: passing argument 3 of '__xa_alloc' makes pointer from integer without a cast [-Wint-conversion]
> err = __xa_alloc(xa, id, *next, entry, GFP_KERNEL);
> ^~~~~
> In file included from include/linux/radix-tree.h:31,
> from include/linux/fs.h:15,
> from include/linux/seq_file.h:11,
> from arch/powerpc/include/asm/machdep.h:12,
> from arch/powerpc/include/asm/archrandom.h:7,
> from include/linux/random.h:166,
> from include/linux/net.h:22,
> from include/linux/skbuff.h:29,
> from include/linux/if_arp.h:26,
> from include/rdma/ib_addr.h:39,
> from include/rdma/rdma_cm.h:39,
> from drivers/infiniband/core/restrack.c:6:
> include/linux/xarray.h:524:61: note: expected 'void *' but argument is of type 'u32' {aka 'unsigned int'}
> int __must_check __xa_alloc(struct xarray *, u32 *id, void *entry,
> ~~~~~~^~~~~
> drivers/infiniband/core/restrack.c:29:35: error: incompatible type for argument 4 of '__xa_alloc'
> err = __xa_alloc(xa, id, *next, entry, GFP_KERNEL);
> ^~~~~
> In file included from include/linux/radix-tree.h:31,
> from include/linux/fs.h:15,
> from include/linux/seq_file.h:11,
> from arch/powerpc/include/asm/machdep.h:12,
> from arch/powerpc/include/asm/archrandom.h:7,
> from include/linux/random.h:166,
> from include/linux/net.h:22,
> from include/linux/skbuff.h:29,
> from include/linux/if_arp.h:26,
> from include/rdma/ib_addr.h:39,
> from include/rdma/rdma_cm.h:39,
> from drivers/infiniband/core/restrack.c:6:
> include/linux/xarray.h:525:3: note: expected 'struct xa_limit' but argument is of type 'void *'
> struct xa_limit, gfp_t);
> ^~~~~~~~~~~~~~~
>
> Caused by commit
>
> fd47c2f99f04 ("RDMA/restrack: Convert internal DB from hash to XArray")
>
> from the rdma tree interacting with commit
>
> a3e4d3f97ec8 ("XArray: Redesign xa_alloc API")
>
> from the xarray tree.
Thanks Stephen, your change looks good.
Matthew, really? change of API in -rc7? And it after you pushed us to
base our -next on -rc5 after another API change? What should we do now?
Can you please ensure that you are sending your pull request to Linus,
after RDMA pull request will be successfully merged?
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2019-02-21 12:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 6:13 linux-next: build failure after merge of the xarray tree Stephen Rothwell
2019-02-21 12:34 ` Leon Romanovsky [this message]
2019-02-21 12:48 ` Stephen Rothwell
2019-02-21 13:16 ` Leon Romanovsky
2019-02-21 13:23 ` Stephen Rothwell
2019-03-11 2:44 ` Matthew Wilcox
2019-03-11 12:13 ` Jason Gunthorpe
2019-03-11 12:31 ` Matthew Wilcox
2019-03-11 14:12 ` Jason Gunthorpe
2019-03-11 12:46 ` Leon Romanovsky
-- strict thread matches above, loose matches on Subject: below --
2020-10-08 6:55 Stephen Rothwell
2020-10-08 14:09 ` Matthew Wilcox
2020-10-08 6:50 Stephen Rothwell
2019-02-12 5:20 Stephen Rothwell
2019-02-12 16:15 ` Matthew Wilcox
2019-02-12 16:23 ` Jason Gunthorpe
2019-02-13 21:26 ` Matthew Wilcox
2019-02-13 22:09 ` Jason Gunthorpe
2019-02-21 12:47 ` Stephen Rothwell
2019-02-21 17:40 ` Jason Gunthorpe
2018-06-18 3:27 Stephen Rothwell
2018-06-18 16:50 ` Dan Williams
2018-06-18 17:09 ` Matthew Wilcox
2018-06-27 3:09 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221123440.GD17501@mtr-leonro.mtl.com \
--to=leonro@mellanox.com \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox