public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Michael Holzheu <holzheu@linux.ibm.com>
Cc: Benjamin Block <bblock@linux.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	dm-devel@redhat.com, linux-next@vger.kernel.org,
	Mikulas Patocka <mpatocka@redhat.com>,
	Steffen Maier <maier@linux.ibm.com>
Subject: Re: linux-next: Boot hangs 3 minutes with device mapper on s390
Date: Fri, 1 Mar 2019 13:30:50 -0500	[thread overview]
Message-ID: <20190301183050.GA29752@redhat.com> (raw)
In-Reply-To: <20190301183350.5ff697d4@TP-holzheu>

On Fri, Mar 01 2019 at 12:33pm -0500,
Michael Holzheu <holzheu@linux.ibm.com> wrote:

> Hi Mike,
> 
> On Fedora 29, the following "linux-next" commit introduced a regression on s390:
> 
>   commit 1efa3bb79d3de8ca1b7f6770313a1fc0bebe25c7
>   Author: Mike Snitzer <snitzer@redhat.com>
>   Date:   Fri Feb 22 11:23:01 2019 -0500
> 
>     dm: must allocate dm_noclone for stacked noclone devices
>     
>     Otherwise various lvm2 testsuite tests fail because the lower layers of
>     the stacked noclone device aren't updated to allocate a new 'struct
>     dm_clone' that reflects the upper layer bio that was issued to it.
>     
>     Fixes: 97a89458020b38 ("dm: improve noclone bio support")
>     Reported-by: Mikulas Patocka <mpatocka@redhat.com>
>     Signed-off-by: Mike Snitzer <snitzer@redhat.com>
> 
> With this commit the boot hangs three minutes on a z/VM system with the
> following device mapper setup:
> 
> # dmsetup ls --tree
> mpathe (252:5)
>  ├─ (8:128)
>  └─ (8:144)
> mpathd (252:4)
>  ├─ (8:96)
>  └─ (8:112)
> mpathc (252:3)
>  ├─ (8:64)
>  └─ (8:80)
> mpathb (252:2)
>  ├─ (8:32)
>  └─ (8:48)
> mpatha1 (252:1)
>  └─mpatha (252:0)
>     ├─ (8:16)
>     └─ (8:0)
> 
> On the console we get messages like the following:
> 
>    10.116863 sd 3:0:0:1083719813: sdj Write Protect is off 
>    10.117170 sd 3:0:0:1083719813: sdj Write cache: enabled, read cache: enabled, doesn't support DPO or FUA 
>    10.130562 sd 3:0:0:1083719813: sdj Attached SCSI disk 
>  A start job is running for udev Wai   Device Initialization (6s / 3min)
>  A start job is running for udev Wai   Device Initialization (6s / 3min)
>  A start job is running for udev Wai   Device Initialization (7s / 3min)
>  A start job is running for udev Wai   Device Initialization (7s / 3min)
>  A start job is running for udev Wai   Device Initialization (8s / 3min)
>  ...
> 
> After three minutes the boot process continues and the system comes.
> 
> As kernel config we used "performance_defconfig" (make performance_defconfig).

I'm struggling to see why this particular change would cause such a boot
stall -- but then resolve itself.

Can you provide the output from 'dmsetup table'?

Multipath defaults to blk-mq (request-based).  The change you've called
into question is related to bio-based DM.  So There must be some
bio-based DM layer ontop of the multipath devices.  Is mpatha1 a
dm-linear device layered ontop of multipath?

Thanks,
Mike

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

       reply	other threads:[~2019-03-01 18:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190301183350.5ff697d4@TP-holzheu>
2019-03-01 18:30 ` Mike Snitzer [this message]
2019-03-04 10:01   ` linux-next: Boot hangs 3 minutes with device mapper on s390 Steffen Maier
2019-03-04 10:03   ` Michael Holzheu
2019-03-05  4:03     ` Mike Snitzer
2019-03-05  9:46       ` Mikulas Patocka
2019-03-05 13:29         ` Mike Snitzer
2019-03-05 18:02       ` Alexander Duyck
2019-03-05 22:21         ` bio-based DM's "noclone" changes have been dropped from 5.1 [was: Re: linux-next: Boot hangs 3 minutes with device mapper on s390] Mike Snitzer
2019-03-07 10:18           ` Michael Holzheu
     [not found] ` <alpine.LRH.2.02.1903011516160.20592@file01.intranet.prod.int.rdu2.redhat.com>
2019-03-01 20:30   ` linux-next: Boot hangs 3 minutes with device mapper on s390 Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190301183050.GA29752@redhat.com \
    --to=snitzer@redhat.com \
    --cc=bblock@linux.ibm.com \
    --cc=dm-devel@redhat.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=holzheu@linux.ibm.com \
    --cc=linux-next@vger.kernel.org \
    --cc=maier@linux.ibm.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox