From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: bio-based DM's "noclone" changes have been dropped from 5.1 [was: Re: linux-next: Boot hangs 3 minutes with device mapper on s390] Date: Tue, 5 Mar 2019 17:21:12 -0500 Message-ID: <20190305222112.GA26427@redhat.com> References: <20190301183350.5ff697d4@TP-holzheu> <20190301183050.GA29752@redhat.com> <20190304110334.6f71962a@TP-holzheu> <20190305040321.GA21739@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Alexander Duyck Cc: Benjamin Block , Heiko Carstens , dm-devel@redhat.com, linux-next@vger.kernel.org, Mikulas Patocka , Steffen Maier , Michael Holzheu List-Id: linux-next.vger.kernel.org On Tue, Mar 05 2019 at 1:02pm -0500, Alexander Duyck wrote: > On Mon, Mar 4, 2019 at 8:03 PM Mike Snitzer wrote: > > > > Hi, > > > > Alexander reported this same boot hang in another thread. I was able to > > reproduce using an x86_64 .config that Alexander provided. > > > > I've pushed this fix out to linux-next: > > https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.1&id=be2c5301817833f692aadb2e5fa209582db01d3b > > > > If you could verify this fix works for you I'd appreciate it. > > > > Thanks, > > Mike > > I've verified I am no longer seeing the issue with this patch applied. Thanks for testing. But so you and others are aware: based on further internal discussion with Mikulas, I decided to drop all the bio-based DM "noclone" changes that were developed for 5.1. Mikulas had a really good point that the 10-13% performance benefit seen with 512b IO workloads all but disappears to only a 1% improvement as soon as the bio's payload is increased to >= 4K. Meaning the risk associated with the noclone changes really is _not_ worth the reward. I've rebased the dm-5.1 branch accordingly and linux-next will pick it up tonight. Mike ps. in case anyone cares, the noclone changes have been preserved in this dm-noclone-support branch: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-noclone-support