From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the nand tree
Date: Tue, 2 Apr 2019 09:27:47 +0200 [thread overview]
Message-ID: <20190402092747.758544a2@xps13> (raw)
In-Reply-To: <1554161512.10471.3@crapouillou.net>
Hi Paul,
Paul Cercueil <paul@crapouillou.net> wrote on Tue, 02 Apr 2019 01:31:52
+0200:
> Hi Stephen,
>
> Le mar. 2 avril 2019 à 1:14, Stephen Rothwell <sfr@canb.auug.org.au> a écrit :
> > Hi all,
> >
> > After merging the nand tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/mtd/nand/raw/ingenic/ingenic_ecc.c:26:5: error: redefinition > of 'ingenic_ecc_calculate'
> > int ingenic_ecc_calculate(struct ingenic_ecc *ecc,
> > ^~~~~~~~~~~~~~~~~~~~~
> > In file included from drivers/mtd/nand/raw/ingenic/ingenic_ecc.c:14:
> > drivers/mtd/nand/raw/ingenic/ingenic_ecc.h:39:5: note: previous > definition of 'ingenic_ecc_calculate' was here
> > int ingenic_ecc_calculate(struct ingenic_ecc *ecc,
> > ^~~~~~~~~~~~~~~~~~~~~
> > drivers/mtd/nand/raw/ingenic/ingenic_ecc.c:47:5: error: redefinition > of 'ingenic_ecc_correct'
> > int ingenic_ecc_correct(struct ingenic_ecc *ecc,
> > ^~~~~~~~~~~~~~~~~~~
> > In file included from drivers/mtd/nand/raw/ingenic/ingenic_ecc.c:14:
> > drivers/mtd/nand/raw/ingenic/ingenic_ecc.h:46:5: note: previous > definition of 'ingenic_ecc_correct' was here
> > int ingenic_ecc_correct(struct ingenic_ecc *ecc,
> > ^~~~~~~~~~~~~~~~~~~
> > drivers/mtd/nand/raw/ingenic/ingenic_ecc.c:93:21: error: redefinition > of 'of_ingenic_ecc_get'
> > struct ingenic_ecc *of_ingenic_ecc_get(struct device_node *of_node)
> > ^~~~~~~~~~~~~~~~~~
> > In file included from drivers/mtd/nand/raw/ingenic/ingenic_ecc.c:14:
> > drivers/mtd/nand/raw/ingenic/ingenic_ecc.h:57:21: note: previous > definition of 'of_ingenic_ecc_get' was here
> > struct ingenic_ecc *of_ingenic_ecc_get(struct device_node *np)
> > ^~~~~~~~~~~~~~~~~~
> > drivers/mtd/nand/raw/ingenic/ingenic_ecc.c:119:6: error: redefinition > of 'ingenic_ecc_release'
> > void ingenic_ecc_release(struct ingenic_ecc *ecc)
> > ^~~~~~~~~~~~~~~~~~~
> > In file included from drivers/mtd/nand/raw/ingenic/ingenic_ecc.c:14:
> > drivers/mtd/nand/raw/ingenic/ingenic_ecc.h:53:6: note: previous > definition of 'ingenic_ecc_release' was here
> > void ingenic_ecc_release(struct ingenic_ecc *ecc)
> > ^~~~~~~~~~~~~~~~~~~
> >
> > Caused by commit
> >
> > 8278ad0d709a ("mtd: rawnand: ingenic: Separate top-level and SoC > specific code")
> >
> > I have used the nand tree from next-20190401 for today.
>
> That makes no sense to me; from the offsets of the errors in the ingenic_ecc.h
> file, it seems that CONFIG_MTD_NAND_INGENIC_ECC is not set, and in this case
> ingenic_ecc.c should not be compiled at all.
>
> -Paul
>
>
There must be a mistmatch somewhere in Kconfig, please reproduce with
allmodconfig on x86_64, I don't have time to check on this today.
Otherwise I'll have to drop the patchset :/
Thanks,
Miquèl
next prev parent reply other threads:[~2019-04-02 7:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 23:14 linux-next: build failure after merge of the nand tree Stephen Rothwell
2019-04-01 23:31 ` Paul Cercueil
2019-04-02 7:27 ` Miquel Raynal [this message]
2019-04-02 9:21 ` Miquel Raynal
2019-04-02 11:56 ` Miquel Raynal
2019-04-02 12:00 ` Paul Cercueil
2019-04-02 12:16 ` Miquel Raynal
-- strict thread matches above, loose matches on Subject: below --
2020-03-11 2:16 Stephen Rothwell
2020-03-11 10:10 ` Miquel Raynal
2020-03-11 14:01 ` Boris Brezillon
2020-03-11 19:20 ` Janusz Krzysztofik
2020-05-12 4:08 Stephen Rothwell
2020-05-12 7:04 ` Miquel Raynal
2020-05-25 10:45 Stephen Rothwell
2020-05-25 11:54 ` Miquel Raynal
2020-09-08 3:35 Stephen Rothwell
2020-09-10 4:12 ` Stephen Rothwell
2020-09-11 16:58 ` Miquel Raynal
2020-09-14 1:45 Stephen Rothwell
2020-09-14 9:50 ` Alex Dewar
2020-09-14 10:58 ` Miquel Raynal
2020-12-08 2:14 Stephen Rothwell
2022-09-21 1:32 Stephen Rothwell
2023-08-21 2:02 Stephen Rothwell
2023-08-21 5:44 ` Md Sadre Alam
2025-01-06 1:48 Stephen Rothwell
2025-01-06 1:51 ` Stephen Rothwell
2025-01-06 6:16 ` Md Sadre Alam
2025-01-06 13:23 ` Md Sadre Alam
2025-01-07 1:46 ` Stephen Rothwell
2025-01-16 2:20 Stephen Rothwell
2025-01-17 2:23 ` Stephen Rothwell
2025-01-17 8:25 ` Miquel Raynal
2025-03-04 2:28 Stephen Rothwell
2025-03-04 10:57 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402092747.758544a2@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).