public inbox for linux-next@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Yifeng Li <tomli@tomli.me>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Kees Cook <keescook@chromium.org>
Subject: linux-next: build warning after merge of the fbdev tree
Date: Tue, 2 Apr 2019 09:30:07 +1100	[thread overview]
Message-ID: <20190402093007.0b03b02e@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

Hi Bartlomiej,

After merging the fbdev tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/video/fbdev/sm712fb.c: In function 'smtc_blank':
drivers/video/fbdev/sm712fb.c:900:4: warning: this statement may fall through [-Wimplicit-fallthrough=]
    smtc_seqw(0x6b, 0x02);
    ^~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/sm712fb.c:901:3: note: here
   case 0x720:
   ^~~~

Introduced by commit

  f627caf55b8e ("fbdev: sm712fb: fix crashes and garbled display during DPMS modesetting")

I get this warning because I am building with -Wimplicit-fallthrough
in attempt to catch new additions early.  The gcc warning can be turned
off by adding a /* fall through */ comment at the point the fall through
happens (assuming that the fall through is intentional).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2019-04-01 22:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-01 22:30 Stephen Rothwell [this message]
2019-04-02 12:38 ` linux-next: build warning after merge of the fbdev tree Tom Li
2019-04-02 15:16   ` Bartlomiej Zolnierkiewicz
  -- strict thread matches above, loose matches on Subject: below --
2022-11-15  0:20 Stephen Rothwell
2022-11-15  5:20 ` Helge Deller
2019-06-11  0:42 Stephen Rothwell
2017-08-02  1:32 Stephen Rothwell
2011-12-20  5:32 Stephen Rothwell
2011-12-20 10:37 ` Laurent Pinchart
2011-12-20 13:48   ` Geert Uytterhoeven
2011-12-20 15:19     ` Laurent Pinchart
2011-12-20 15:24       ` Geert Uytterhoeven
2011-12-20 15:42         ` Laurent Pinchart
2011-12-20 15:48           ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190402093007.0b03b02e@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=b.zolnierkie@samsung.com \
    --cc=gustavo@embeddedor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=tomli@tomli.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox