linux-next: Fixes tags need some work in the cifs tree

linux-next: Fixes tags need some work in the cifs tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 978 bytes --]

Hi all,

In commit

  7d672725ba72 ("cifs: Fix lease buffer length error")

Fixes tags

  Fixes: 9764c02fcbad(SMB3: Add support for multidialect negotiate (SMB2.1 and later))
  Fixes: d5c7076b772a(smb3: add smb3.1.1 to default dialect list)

has these problem(s):

  - missing space between the SHA1 and the subject
  - missing quotes around the subject

In commit

  54492efdd6a2 ("cifs: Fix use-after-free in SMB2_read")

Fixes tag

  Fixes: eccb4422cf97(smb3: Add ftrace tracepoints for improved SMB3 debugging)

has these problem(s):

  - missing space between the SHA1 and the subject
  - missing quotes around the subject

In commit

  3cc71735cf9f ("cifs: Fix use-after-free in SMB2_write")

Fixes tag

  Fixes: eccb4422cf97(smb3: Add ftrace tracepoints for improved SMB3 debugging)

has these problem(s):

  - missing space between the SHA1 and the subject
  - missing quotes around the subject

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tags need some work in the cifs tree

[Steve French]

I just fixed these up manually and repushed to cifs-2.6.git for-next

I was curious if checkpatch should have flagged this - I reran
checkpatch on the original version of Zhang's patches and it didn't
complain about the spacing (and probably should have).

On Mon, Apr 8, 2019 at 4:38 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
>   7d672725ba72 ("cifs: Fix lease buffer length error")
>
> Fixes tags
>
>   Fixes: 9764c02fcbad(SMB3: Add support for multidialect negotiate (SMB2.1 and later))
>   Fixes: d5c7076b772a(smb3: add smb3.1.1 to default dialect list)
>
> has these problem(s):
>
>   - missing space between the SHA1 and the subject
>   - missing quotes around the subject
>
> In commit
>
>   54492efdd6a2 ("cifs: Fix use-after-free in SMB2_read")
>
> Fixes tag
>
>   Fixes: eccb4422cf97(smb3: Add ftrace tracepoints for improved SMB3 debugging)
>
> has these problem(s):
>
>   - missing space between the SHA1 and the subject
>   - missing quotes around the subject
>
> In commit
>
>   3cc71735cf9f ("cifs: Fix use-after-free in SMB2_write")
>
> Fixes tag
>
>   Fixes: eccb4422cf97(smb3: Add ftrace tracepoints for improved SMB3 debugging)
>
> has these problem(s):
>
>   - missing space between the SHA1 and the subject
>   - missing quotes around the subject
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve

Re: linux-next: Fixes tags need some work in the cifs tree

[Stephen Rothwell]

[-- Attachment #1.1: Type: text/plain, Size: 624 bytes --]

Hi Steve,

On Mon, 8 Apr 2019 17:30:20 -0500 Steve French <smfrench@gmail.com> wrote:
>
> I just fixed these up manually and repushed to cifs-2.6.git for-next

Thanks.

> I was curious if checkpatch should have flagged this - I reran
> checkpatch on the original version of Zhang's patches and it didn't
> complain about the spacing (and probably should have).

Yeah, I use the attached script to check for these.  I was hoping that
someone might hack at least some of theses tests into checkpatch, but
that hasn't happened yet :-(  But, then again, I don't run checkpatch :-)
-- 
Cheers,
Stephen Rothwell

[-- Attachment #1.2: check_fixes --]
[-- Type: application/x-shellscript, Size: 4344 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]