linux-next: Signed-off-by missing for commit in the battery tree

linux-next: Signed-off-by missing for commit in the battery tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

Hi Sebastian,

Commit

  465089b4abe0 ("TODO")

is missing a Signed-off-by from its author and committer.

Not much of a commit message either :-)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the battery tree

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

Hi,

On Thu, May 02, 2019 at 07:52:38AM +1000, Stephen Rothwell wrote:
> Hi Sebastian,
> 
> Commit
> 
>   465089b4abe0 ("TODO")
> 
> is missing a Signed-off-by from its author and committer.
> 
> Not much of a commit message either :-)

oops, thanks for the hint :) Dropped!

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: Signed-off-by missing for commit in the battery tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi all,

Commit

  8543d1c462e2 ("power: supply: sbs-charger: Support multiple devices")

is missing a Signed-off-by from its author.

Actually the author in the commit is

  fabien.proriol@kazoe.org <fabien.proriol@kazoe.org>

While the SoB line is

  Signed-off-by: Fabien Proriol <fabien.proriol@viavisolutions.com>

We should prefer that they match.  Also we prefer full names in all
email addresses.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the battery tree

[Fabien Proriol]

Hi,

In fact, <fabien.proriol@viavisolutions.com> is the email of my 
companies, unfortunately, the email server broke the indentation of my 
patch.
This why I used my own personal address to re-send the same commit 
(<fabien.proriol@kazoe.org>).

For me, we can use either one without any problem, so, if you can change 
to use the same in the signed-off and the commit, it's OK for me.

How to process ? can you change it or, should I re-transmit the message 
again ?

Thanks,

Fabien Proriol

Le 08/09/2025 à 00:07, Stephen Rothwell a écrit :
> Hi all,
>
> Commit
>
>    8543d1c462e2 ("power: supply: sbs-charger: Support multiple devices")
>
> is missing a Signed-off-by from its author.
>
> Actually the author in the commit is
>
>    fabien.proriol@kazoe.org <fabien.proriol@kazoe.org>
>
> While the SoB line is
>
>    Signed-off-by: Fabien Proriol <fabien.proriol@viavisolutions.com>
>
> We should prefer that they match.  Also we prefer full names in all
> email addresses.
>

Re: linux-next: Signed-off-by missing for commit in the battery tree

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

Hello Fabien,

Please do not top-top :)

>Le 08/09/2025 à 00:07, Stephen Rothwell a écrit :
>> Commit
>>    8543d1c462e2 ("power: supply: sbs-charger: Support multiple devices")
>> is missing a Signed-off-by from its author.
>
> In fact, <fabien.proriol@viavisolutions.com> is the email of my companies,
> unfortunately, the email server broke the indentation of my patch.
> This why I used my own personal address to re-send the same commit
> (<fabien.proriol@kazoe.org>).

Actually your second patch was also broken and I had to fix it up
while applying. You should have a look at 'b4', which helps you a
lot with these kind of issues:

https://b4.docs.kernel.org/en/latest/

> For me, we can use either one without any problem, so, if you can change to
> use the same in the signed-off and the commit, it's OK for me.
> 
> How to process ? can you change it or, should I re-transmit the message
> again ?

The first patch was send by your work mail and signed off by it.
I've used that to fix things up.

Please have a look at fixing your mail setup before sending more
patches - be it with b4 or via some other setup :)

Greetings,

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

linux-next: Signed-off-by missing for commit in the battery tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

Hi all,

Commit

  e748590daf72 ("power: supply: PCHG: Use MKBP for device event handling")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the battery tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

Hi Sebastian,

Commit

  5e0dfcbb1194 ("max17042: propagate of_node to power supply device")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the battery tree

[Pierre Bourdon (delroth)]

On Mon, Mar 12, 2018 at 10:35 AM, Pierre Bourdon (delroth)
<delroth@google.com> wrote:
> On Mon, 12 Mar 2018 at 02:40, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> Hi Sebastian,
>>
>> Commit
>>
>>   5e0dfcbb1194 ("max17042: propagate of_node to power supply device")
>>
>> is missing a Signed-off-by from its author.
>
> I failed hard :) will resend.

So, since I'm very clearly not familiar with the process... is sending
a v2 with proper s-o-b the Right Way to do it, or are you just fine
with a correction by email?

If the latter:

Signed-off-by: Pierre Bourdon <delroth@google.com>

Sorry for the screwup, slowly learning (I hope).
Best,

-- 
Pierre Bourdon (delroth@)

Re: linux-next: Signed-off-by missing for commit in the battery tree

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

Hi Stephen and Pierre,

On Mon, Mar 12, 2018 at 10:46:08AM +0100, Pierre Bourdon (delroth) wrote:
> On Mon, Mar 12, 2018 at 10:35 AM, Pierre Bourdon (delroth)
> <delroth@google.com> wrote:
> > On Mon, 12 Mar 2018 at 02:40, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >>
> >> Hi Sebastian,
> >>
> >> Commit
> >>
> >>   5e0dfcbb1194 ("max17042: propagate of_node to power supply device")
> >>
> >> is missing a Signed-off-by from its author.

Thanks for the hint!

> > I failed hard :) will resend.
> 
> So, since I'm very clearly not familiar with the process... is sending
> a v2 with proper s-o-b the Right Way to do it, or are you just fine
> with a correction by email?
> 
> If the latter:
> 
> Signed-off-by: Pierre Bourdon <delroth@google.com>
> 
> Sorry for the screwup, slowly learning (I hope).
> Best,

Thanks for your SoB. I fixed this up in the existing patch.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]