From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: Tree for Jul 2 (objtool)
Date: Wed, 3 Jul 2019 16:03:53 -0500 [thread overview]
Message-ID: <20190703210353.ejvwtew3zsl4o3zh@treble> (raw)
In-Reply-To: <20190703194614.6bsyfspnpcf4dhfj@treble>
On Wed, Jul 03, 2019 at 02:46:14PM -0500, Josh Poimboeuf wrote:
> On Wed, Jul 03, 2019 at 02:45:28PM -0500, Josh Poimboeuf wrote:
> > On Wed, Jul 03, 2019 at 10:23:21AM -0700, Randy Dunlap wrote:
> > > On 7/3/19 9:44 AM, Josh Poimboeuf wrote:
> > > > On Tue, Jul 02, 2019 at 11:47:02AM -0700, Randy Dunlap wrote:
> > > >> On 7/2/19 2:51 AM, Stephen Rothwell wrote:
> > > >>> Hi all,
> > > >>>
> > > >>> Changes since 20190701:
> > > >>>
> > > >>
> > > >> on x86_64:
> > > >>
> > > >> kernel/bpf/core.o: warning: objtool: ___bpf_prog_run()+0x22: can't find switch jump table
> > > >
> > > > I don't see it on current linux-next/master. Can you share the config
> > > > and .o?
> > > >
> > >
> > > This warning happened in 6 of 10 builds for 20190702.
> > >
> > > Today (20190703) I don't see it at all, but I see this instead:
> > > kernel/bpf/core.o: warning: objtool: ___bpf_prog_run()+0xa3: sibling call from callable instruction with modified stack frame
> > >
> > > Kernel (rand)config file and .o file for 20190702 are attached.
> >
> > Thanks, I'm able to recreate the sibling call warning with a randconfig
> > on today's linux-next.
> >
> > GCC is doing some funky stuff. With my randconfig, ___bpf_prog_run()
> > has 166 indirect calls to its jump table. Seems (a bit!) excessive.
>
> s/calls/jumps/ obviously
>
> >
> > I'll need to look into it.
Hm, it looks like disabling CONFIG_RETPOLINE causes GCC to produce
vastly different code here. Without retpolines, it's not shy at all
about indirect jumps.
--
Josh
prev parent reply other threads:[~2019-07-03 21:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 9:51 linux-next: Tree for Jul 2 Stephen Rothwell
2019-07-02 10:40 ` Zhangshaokun
2019-07-02 12:03 ` Will Deacon
2019-07-02 12:22 ` Zhangshaokun
2019-07-02 15:14 ` Joerg Roedel
2019-07-02 18:47 ` linux-next: Tree for Jul 2 (objtool) Randy Dunlap
2019-07-03 16:44 ` Josh Poimboeuf
2019-07-03 17:23 ` Randy Dunlap
2019-07-03 19:45 ` Josh Poimboeuf
2019-07-03 19:46 ` Josh Poimboeuf
2019-07-03 21:03 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703210353.ejvwtew3zsl4o3zh@treble \
--to=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox