From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: linux-next: Tree for Jul 18 (header build error)
Date: Thu, 18 Jul 2019 17:30:45 -0700 [thread overview]
Message-ID: <20190719003045.GF692234@magnolia> (raw)
In-Reply-To: <20190719100557.3ead3285@canb.auug.org.au>
On Fri, Jul 19, 2019 at 10:05:57AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> On Thu, 18 Jul 2019 10:00:22 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > on x86_64, when CONFIG_BLOCK is not set:
> >
> > CC include/linux/iomap.h.s
> > In file included from <command-line>:0:0:
> > ./../include/linux/iomap.h: In function ‘iomap_sector’:
> > ./../include/linux/iomap.h:76:48: error: ‘SECTOR_SHIFT’ undeclared (first use in this function); did you mean ‘SECTIONS_SHIFT’?
> > return (iomap->addr + pos - iomap->offset) >> SECTOR_SHIFT;
> > ^~~~~~~~~~~~
>
> include/linux/iomap.h should only be used when CONFIG_BLOCK is set (if
> you follow the Kconfig trail). So maybe this header should only be
> compile tested if CONFIG_BLOCK is set.
Yeah, that's basically what Christoph said earlier today.
Granted, nobody replied to my question about where in the kernel would
someone be using iomap to map file offsets to disk locations without
block devices, but ...
... oh, this is some weird "mash all the kernel headers together and see
if they compile" thing, isn't it? Um, yes, iomap.h should only be
tested if CONFIG_IOMAP=y (which in turn requires CONFIG_BLOCK=y).
--D
> --
> Cheers,
> Stephen Rothwell
next prev parent reply other threads:[~2019-07-19 0:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 3:37 linux-next: Tree for Jul 18 Stephen Rothwell
2019-07-18 17:00 ` linux-next: Tree for Jul 18 (header build error) Randy Dunlap
2019-07-19 0:05 ` Stephen Rothwell
2019-07-19 0:30 ` Darrick J. Wong [this message]
2019-07-19 0:40 ` Stephen Rothwell
2019-07-19 0:36 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719003045.GF692234@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox