From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02908C7618F for ; Fri, 19 Jul 2019 00:36:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0D7C2077C for ; Fri, 19 Jul 2019 00:36:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="exsrLHOk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726045AbfGSAgI (ORCPT ); Thu, 18 Jul 2019 20:36:08 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:54667 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbfGSAgI (ORCPT ); Thu, 18 Jul 2019 20:36:08 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 45qX9d58p6z9s3Z; Fri, 19 Jul 2019 10:36:05 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1563496565; bh=A+TA+2R+siqm/hZzdzM+n47UXTwyBo0+6SZwnCK3ldU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=exsrLHOk4/j+LH0kK1phxyWNQDVN2ShZz3o6sfxhjGrfJGYy/AtnN7oWTFAnGjGNz pdB1v94JZKzv/9N4KJingJ3MQEeaWU0Vgi/Yn8aVSyPhlFoRl+LRboC3rhB+VZNz6L ZZaRP89R1IKh6wFN3FOWzNwGUOubYLrH2TK9myeZyGZfINY00eHlYRNI9bVX2BpjKQ x/aOHb0mkeVFmRJxiscHN9eLF/WyoLtcIWdx3HO07+wSjwTNhZ6vKZ4wxKa33BcqsO zqn/qiH0uT554GHjOjYapmm6ATgvAEZT0EhIzG1lzyAzgNuyGWmpv8iHzxTicrKzX0 7Ig7Vb2Jh0Q4g== Date: Fri, 19 Jul 2019 10:36:05 +1000 From: Stephen Rothwell To: Randy Dunlap Cc: Linux Next Mailing List , Linux Kernel Mailing List , Masahiro Yamada , linux-kbuild , "Darrick J. Wong" Subject: Re: linux-next: Tree for Jul 18 (header build error) Message-ID: <20190719103605.5ee9198a@canb.auug.org.au> In-Reply-To: <20190719100557.3ead3285@canb.auug.org.au> References: <20190718133751.3cf036be@canb.auug.org.au> <127d228c-322d-6349-382b-d304974df148@infradead.org> <20190719100557.3ead3285@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/bCrC30V_16tyleeOcNzjhRQ"; protocol="application/pgp-signature"; micalg=pgp-sha256 Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org --Sig_/bCrC30V_16tyleeOcNzjhRQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi all, On Fri, 19 Jul 2019 10:05:57 +1000 Stephen Rothwell = wrote: > > On Thu, 18 Jul 2019 10:00:22 -0700 Randy Dunlap w= rote: > > > > on x86_64, when CONFIG_BLOCK is not set: > >=20 > > CC include/linux/iomap.h.s > > In file included from :0:0: > > ./../include/linux/iomap.h: In function =E2=80=98iomap_sector=E2=80=99: > > ./../include/linux/iomap.h:76:48: error: =E2=80=98SECTOR_SHIFT=E2=80=99= undeclared (first use in this function); did you mean =E2=80=98SECTIONS_SH= IFT=E2=80=99? > > return (iomap->addr + pos - iomap->offset) >> SECTOR_SHIFT; > > ^~~~~~~~~~~~ =20 >=20 > include/linux/iomap.h should only be used when CONFIG_BLOCK is set (if > you follow the Kconfig trail). So maybe this header should only be > compile tested if CONFIG_BLOCK is set. Or maybe fs/iomap/ needs to grow a private header file for stuff like iomap_sector() ? --=20 Cheers, Stephen Rothwell --Sig_/bCrC30V_16tyleeOcNzjhRQ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl0xEHUACgkQAVBC80lX 0GzBlAgAi0HSYElWpG7qvU6y21A8vri4QTUVA0mIE8DqRqX2pjgUOPmQaaGge2u+ Q58vKppAl1Dzt8qbUI9B6xBR4TrbXjqTTRhZHTuWwO0UbHB8rBW4amAVqZMFlXx6 iJq8CdnB/Cdltv434Nilsk5R9PIn3ePDgvyxuc9xgEJ3ZIckceT/zntjqNiJJUBs egV9XQokaGfQRFKnVK6sqrRgZV0k7YU+Yb396N8I8+Zy3PKMCvj1WERFlp+BOmJ5 TTAii5R0hjA5cCLnYia6f4LCO+bNWduuuiv0/oUv32iv0yWpgFLKbqO+astE09f4 3JMCCpjfRvlGLUbZZTneZdp+h4AHlQ== =+bDW -----END PGP SIGNATURE----- --Sig_/bCrC30V_16tyleeOcNzjhRQ--