From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59605C433FF for ; Wed, 7 Aug 2019 01:50:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 281FB217F5 for ; Wed, 7 Aug 2019 01:50:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="JbhrSn2j" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729879AbfHGBur (ORCPT ); Tue, 6 Aug 2019 21:50:47 -0400 Received: from ozlabs.org ([203.11.71.1]:45685 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729968AbfHGBur (ORCPT ); Tue, 6 Aug 2019 21:50:47 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 463Dx02dC1z9sDB; Wed, 7 Aug 2019 11:50:44 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1565142644; bh=Vm8iaukqOL/IY8DFFB9QZrcBEKE3k7jhZco/mWO3qdA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JbhrSn2jDqXOMaEdaPcHTnaSpvnLAxHqcrsUtR8zCo+OJfCC4llmm/Ljk0c/fUGOw YD2igJWbHFhCRdF9gLa/9SIokSYPFZ2fxGS9Ucy3KzCGBsRHM+W/220cYDq5Xbf+YE uTWFbsHl7PTMit0KCrjfFOg8Za3fObTKaJzocLDPvmF2fUJVRbQ+CkfjqMXCKr/oeb jSE70bTTcwxitHdB+jd7d9IID32+pl6DBKIBczrp8g0SCj1ikYvp8wQHfFYckojgLi ZHny7Z+M6Nf8348vaZSh4DMT0hkYKh6hYEKtNCcC525syK7QoOdfHINqLIpdv/C0xi N2CsDNCh3CyBg== Date: Wed, 7 Aug 2019 11:50:43 +1000 From: Stephen Rothwell To: Bjorn Andersson Cc: Andy Gross , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Linux Next Mailing List Subject: Re: [PATCH] soc: qcom: socinfo: Annotate switch cases with fall through Message-ID: <20190807115043.2ff429c1@canb.auug.org.au> In-Reply-To: <20190807012457.16820-1-bjorn.andersson@linaro.org> References: <20190807100803.63007737@canb.auug.org.au> <20190807012457.16820-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_//799VrEy/0lurErM4DPjHtu"; protocol="application/pgp-signature"; micalg=pgp-sha256 Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org --Sig_//799VrEy/0lurErM4DPjHtu Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Bjorn, On Tue, 6 Aug 2019 18:24:57 -0700 Bjorn Andersson wrote: > > qcom_socinfo->dbg_root, > &qcom_socinfo->info.raw_device_num); > + /* Fall through */ > case SOCINFO_VERSION(0, 11): > + /* Fall through */ > case SOCINFO_VERSION(0, 10): > + /* Fall through */ > case SOCINFO_VERSION(0, 9): I don't think you need the comment between consecutive "case"s - just where there is actual code. --=20 Cheers, Stephen Rothwell --Sig_//799VrEy/0lurErM4DPjHtu Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl1KLnMACgkQAVBC80lX 0GyYUQgAgzzUeMJddV/IvgpdCqEA3DrLLwJkuL0zJW6B0gG6S6UusJz2JnB8oEO+ fN5N0Pgva4PpbOV//MBuaC3ITwQBW2mTFAqysPl1dhQaQYRA1R7EvY/wbqZ2vZB2 VOS4KyggeFeFe4PAVvhfzFp0BYUI/u4n4ZCCAhr5EMHgBnv4BXRpno2ufy9sQi+A 7G/pnMqIBhz7p5JJnz2G3QQpFfohrM0ewG6gezNf0toi9Wxyes32+GGVRXWjeQ3H PWGJSvdZnrMAprePhDrcNzUH/OFlj3DnYMSTqA+JFoOK+bIVh5rfX/juSJ6tGzSx 2G5iR0mdMAAPfXqrg58w3vBXiA+PXQ== =+k0V -----END PGP SIGNATURE----- --Sig_//799VrEy/0lurErM4DPjHtu--