linux-next: Fixes tag needs some work in the pm tree

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

Hi all,

In commit

  f43e075f7252 ("cpufreq/pasemi: fix an use-after-free in pas_cpufreq_cpu_init()")

Fixes tag

  Fixes: a9acc26b75f ("cpufreq/pasemi: fix possible object reference leak")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Hi all,

In commit

  fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")

Fixes tag

  Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Did you mean

Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")

or

Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pm tree

[Heikki Krogerus]

On Wed, Sep 11, 2019 at 12:33:06AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")
> 
> Fixes tag
> 
>   Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> Did you mean
> 
> Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")
> 
> or
> 
> Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")

Rafael, it seems you have rebased your branch. Do you want me to
resend those fixes, or can you fix the tags in them yourself?

thanks,

-- 
heikki

Re: linux-next: Fixes tag needs some work in the pm tree

[Rafael J. Wysocki]

On Wednesday, September 11, 2019 9:27:41 AM CEST Heikki Krogerus wrote:
> On Wed, Sep 11, 2019 at 12:33:06AM +1000, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")
> > 
> > Fixes tag
> > 
> >   Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")
> > 
> > has these problem(s):
> > 
> >   - Subject does not match target commit subject
> >     Just use
> > 	git log -1 --format='Fixes: %h ("%s")'
> > 
> > Did you mean
> > 
> > Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")
> > 
> > or
> > 
> > Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
> 
> Rafael, it seems you have rebased your branch.

No, I haven't.

Actually, the commit ID is correct, but the name isn't.

You'd have been unlikely to get a valid commit ID matching anything with
"software node" in the subject had it been rebased. :-)

> Do you want me to resend those fixes, or can you fix the tags in them
> yourself?

I fixed that tag up.

Thanks,
Rafael

Re: linux-next: Fixes tag needs some work in the pm tree

[Heikki Krogerus]

On Wed, Sep 11, 2019 at 07:17:52PM +0200, Rafael J. Wysocki wrote:
> On Wednesday, September 11, 2019 9:27:41 AM CEST Heikki Krogerus wrote:
> > On Wed, Sep 11, 2019 at 12:33:06AM +1000, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > In commit
> > > 
> > >   fd3f7275826f ("software node: Initialize the return value in software_node_find_by_name()")
> > > 
> > > Fixes tag
> > > 
> > >   Fixes: 1666faedb567 ("software node: Add software_node_get_reference_args()")
> > > 
> > > has these problem(s):
> > > 
> > >   - Subject does not match target commit subject
> > >     Just use
> > > 	git log -1 --format='Fixes: %h ("%s")'
> > > 
> > > Did you mean
> > > 
> > > Fixes: 1666faedb567 ("software node: Add software_node_find_by_name()")
> > > 
> > > or
> > > 
> > > Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()")
> > 
> > Rafael, it seems you have rebased your branch.
> 
> No, I haven't.
> 
> Actually, the commit ID is correct, but the name isn't.
> 
> You'd have been unlikely to get a valid commit ID matching anything with
> "software node" in the subject had it been rebased. :-)

Ah. I've added the tag line manually (for some reason). I'm sorry
about that. I usually use this:

        % git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"

> > Do you want me to resend those fixes, or can you fix the tags in them
> > yourself?
> 
> I fixed that tag up.

Thanks Rafael!

-- 
heikki

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi all,

In commit

  b2afd668c323 ("ACPI / utils: Move acpi_dev_get_first_match_dev() under CONFIG_ACPI")

Fixes tag

  Fixes: 817b4d64da03 ("Introduce acpi_dev_get_first_match_dev() helper")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pm tree

[Rafael J. Wysocki]

On Monday, October 14, 2019 10:59:04 PM CEST Stephen Rothwell wrote:
> 
> --Sig_/eM_f_lhAmw+jp3bqTr5YSMd
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi all,
> 
> In commit
> 
>   b2afd668c323 ("ACPI / utils: Move acpi_dev_get_first_match_dev() under CO=
> NFIG_ACPI")
> 
> Fixes tag
> 
>   Fixes: 817b4d64da03 ("Introduce acpi_dev_get_first_match_dev() helper")
> 
> has these problem(s):
> 
>   - Subject does not match target commit subject

Fixed, thanks!

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi all,


  78d3e7c19e2d ("tools/power/acpi: fix compilation error")

Fixes tag

  Fixes: d5a4b1a540b ("tools/power/acpi: Remove direct kernel source include reference")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Hi all,

In commit

  ea28c454067f ("docs: cpufreq: fix a broken reference")

Fixes tag

  Fixes: 78a0abeca1bd ("Documentation: cpufreq: Move legacy driver documentation")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 03b22496502d ("Documentation: cpufreq: Move legacy driver documentation")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

Hi all,

In commit

  ceac7fc18ac7 ("opp: Enable resources again if they were disabled earlier")

Fixes tag

  Fixes: cd7ea582 ("opp: Make dev_pm_opp_set_rate() handle freq = 0 to drop performance votes")

has these problem(s):

  - SHA1 should be at least 12 digits long
    Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
    or later) just making sure it is not set (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pm tree

[Viresh Kumar]

On 20-08-20, 08:01, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   ceac7fc18ac7 ("opp: Enable resources again if they were disabled earlier")
> 
> Fixes tag
> 
>   Fixes: cd7ea582 ("opp: Make dev_pm_opp_set_rate() handle freq = 0 to drop performance votes")
> 
> has these problem(s):
> 
>   - SHA1 should be at least 12 digits long
>     Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
>     or later) just making sure it is not set (or set to "auto").

It came from the author and I failed to verify it :(

Rafael: Do you want me to resend the pull request with this fixed ? Or
something else ?

-- 
viresh

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

Hi all,

In commit

  fa26d0c778b4 ("ACPI: processor: Fix build when CONFIG_ACPI_PROCESSOR=m")

Fixes tag

  Fixes: 8cdddd182bd7 ("CPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pm tree

[Vitaly Kuznetsov]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi all,
>
> In commit
>
>   fa26d0c778b4 ("ACPI: processor: Fix build when CONFIG_ACPI_PROCESSOR=m")
>
> Fixes tag
>
>   Fixes: 8cdddd182bd7 ("CPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()")

"A" in "ACPI" seems to be missing

>
> has these problem(s):
>
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'

This is an extremely unlucky fix :-( 

-- 
Vitaly

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

In commit

  42d2607d91c4 ("PM / devfreq: passive: Return non-error when not-supported event is required")

Fixes tag

  Fixes: ce9a0d88d97a ("PM / devfreq: Add cpu based scaling support to passive governor")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: a03dacb0316f ("PM / devfreq: Add cpu based scaling support to passive governor")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

Hi all,

In commit

  bfcdf58380b1 ("ACPI: resource: do IRQ override on LENOVO IdeaPad")

Fixes tag

  Fixes: 37c81d9f1d1b (ACPI: resource: skip IRQ override on AMD Zen platforms)

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen platforms")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

Hi all,

In commit

  4f3085f87b51 ("cpufreq: amd-pstate: fix kernel hang issue while amd-pstate unregistering")

Fixes tag

  Fixes: 1d215f0319 ("cpufreq: amd-pstate: Add fast switch function for AMD P-State")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

Hi all,

In commit

  26c9a5984cba ("thermal: intel: int340x: Fix unitialized variable error")

Fixes tag

  Fixes: d58c653e9e26 ("thermal: intel: int340x: Use generic trip points")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: fecb78002029 ("thermal: intel: int340x: Use generic trip points")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Hi all,

In commit

  43b549c5d8de ("ACPI: property: Polish ignoring bad data nodes")

Fixes tag

  Fixes: 6018731b04ca ("ACPI: property: Ignore bad graph port nodes on Dell XPS 9315")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 5bd4edbbf920 ("ACPI: property: Ignore bad graph port nodes on Dell XPS 9315")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi all,

In commit

  a51ab63b297c ("ACPI: CPPC: enable AMD CPPC V2 support for family 17h processors")

Fixes tag

  Fixes: fbd74d1689 ("ACPI: CPPC: Fix enabling CPPC on AMD systems with shared memory")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

Hi all,

In commit

  f9320cd0fa4b ("ACPICA: events/evxfregn: don't release the ContextMutex that was never acquired")

Fixes tag

  Fixes: c27f3d011b08 ("Fix race in GenericSerialBus (I2C) and GPIO OpRegion parameter handling")

has these problem(s):

  - Subject does not match target commit subject
    Just use
        git log -1 --format='Fixes: %h ("%s")'

i.e.

Fixes: c27f3d011b08 ("ACPICA: Fix race in generic_serial_bus (I2C) and GPIO op_region parameter handling")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi all,

In commit

  f6c0b7602909 ("cpufreq/amd-pstate: Fix the clamping of perf values")

Fixes tag

  Fixes: 305621eb6a8b ("cpufreq/amd-pstate: Modularize perf<->freq conversion")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 620136ced35a ("cpufreq/amd-pstate: Modularize perf<->freq conversion")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pm tree

[Dhananjay Ugwekar]

Hello Stephen,

On 3/6/2025 2:58 AM, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   f6c0b7602909 ("cpufreq/amd-pstate: Fix the clamping of perf values")
> 
> Fixes tag
> 
>   Fixes: 305621eb6a8b ("cpufreq/amd-pstate: Modularize perf<->freq conversion")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: 620136ced35a ("cpufreq/amd-pstate: Modularize perf<->freq conversion")

Yes, you're right, I was referring to that commit,
https://web.git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=620136ced35a9329f4d1ea90e51bee2dfd7ee5b0

Rafael, will you be able to fix the tag it in your tree?, or should I send the amended patch separately?

Thanks,
Dhananjay

> 

Re: linux-next: Fixes tag needs some work in the pm tree

[Rafael J. Wysocki]

On Thursday, March 6, 2025 7:15:57 AM CET Dhananjay Ugwekar wrote:
> Hello Stephen,
> 
> On 3/6/2025 2:58 AM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > In commit
> > 
> >   f6c0b7602909 ("cpufreq/amd-pstate: Fix the clamping of perf values")
> > 
> > Fixes tag
> > 
> >   Fixes: 305621eb6a8b ("cpufreq/amd-pstate: Modularize perf<->freq conversion")
> > 
> > has these problem(s):
> > 
> >   - Target SHA1 does not exist
> > 
> > Maybe you meant
> > 
> > Fixes: 620136ced35a ("cpufreq/amd-pstate: Modularize perf<->freq conversion")
> 
> Yes, you're right, I was referring to that commit,
> https://web.git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=620136ced35a9329f4d1ea90e51bee2dfd7ee5b0
> 
> Rafael, will you be able to fix the tag it in your tree?, or should I send the amended patch separately?

No, I'm not, this was pulled from Mario.

Mario, can you please fix this and send a new pull request to me for the
same material?

Thanks!

Re: linux-next: Fixes tag needs some work in the pm tree

[Mario Limonciello]

On 3/6/2025 10:52, Rafael J. Wysocki wrote:
> On Thursday, March 6, 2025 7:15:57 AM CET Dhananjay Ugwekar wrote:
>> Hello Stephen,
>>
>> On 3/6/2025 2:58 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>>    f6c0b7602909 ("cpufreq/amd-pstate: Fix the clamping of perf values")
>>>
>>> Fixes tag
>>>
>>>    Fixes: 305621eb6a8b ("cpufreq/amd-pstate: Modularize perf<->freq conversion")
>>>
>>> has these problem(s):
>>>
>>>    - Target SHA1 does not exist
>>>
>>> Maybe you meant
>>>
>>> Fixes: 620136ced35a ("cpufreq/amd-pstate: Modularize perf<->freq conversion")
>>
>> Yes, you're right, I was referring to that commit,
>> https://web.git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=620136ced35a9329f4d1ea90e51bee2dfd7ee5b0
>>
>> Rafael, will you be able to fix the tag it in your tree?, or should I send the amended patch separately?
> 
> No, I'm not, this was pulled from Mario.
> 
> Mario, can you please fix this and send a new pull request to me for the
> same material?
> 
> Thanks!
> 
> 
> 

The tag WAS right originally, but I the sha changed when I rebased on a 
later RC and I still had the old sha in my tree so I missed it.

I'll make a replacement tag for you and you can repull.

Thanks,

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

Hi all,

In commit

  0f8af0356a45 ("ACPICA: exserial: don't forget to handle FFixedHW opregions for reading")

Fixes tag

  Fixes: ee64b827a9a ("ACPICA: Add support for FFH Opregion special context data")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the pm tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

Hi all,

In commit

  b2f79c0b8352 ("ACPICA: Utilities: Fix spelling mistake "Incremement" -> "Increment"")

Fixes tag

  Fixes: a171306ed1a1 ("Reference count: add additional debugging details)

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: ff5340f8ac94 ("ACPICA: Reference count: add additional debugging details")

Also, please keep all the commit message trailer tags together at the
end of the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the pm tree

[Rafael J. Wysocki]

On Wednesday, April 30, 2025 12:53:12 AM CEST Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   b2f79c0b8352 ("ACPICA: Utilities: Fix spelling mistake "Incremement" -> "Increment"")
> 
> Fixes tag
> 
>   Fixes: a171306ed1a1 ("Reference count: add additional debugging details)
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Maybe you meant
> 
> Fixes: ff5340f8ac94 ("ACPICA: Reference count: add additional debugging details")

Yes, this is the commit that is fixed.

> Also, please keep all the commit message trailer tags together at the
> end of the commit message.

And it should be corrected now, thanks for the report!