From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48572C4CECD for ; Tue, 17 Sep 2019 07:52:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A583206C2 for ; Tue, 17 Sep 2019 07:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568706768; bh=rmvZT8k3qn19JgvHsBeX3+3UmKBjUPk1QS/Hl6FZYIg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VGapzm+p2NfQBWYrzEMQmlN8wK9aXdD8FWzc2De7GQlI8kAm5AIfspCwEKbGOttqC An3OzP/FmXQN1LFwN4ITeAkugjT2UKjrEuysy9Gsq4lIC/pUnx6US1KeftdK81kozS UXvCFYXHS2eNYIB2aNTW3ZMikRmEkLDtLsdaEauk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404543AbfIQHwr (ORCPT ); Tue, 17 Sep 2019 03:52:47 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:35578 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404523AbfIQHwr (ORCPT ); Tue, 17 Sep 2019 03:52:47 -0400 Received: by mail-wr1-f67.google.com with SMTP id v8so2030282wrt.2; Tue, 17 Sep 2019 00:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=cdNFOd7zQsAnR9pP9FzvoRQoGQj1w1WjpRlr+NKG8I4=; b=EuOgRWTJsovgapyFUlWA/qL2ETB+kVNHua2oqHt+kwovPDpqoZPLoSGi1kLlGUaCE2 ZqQ/g5P3xAI5NX10qznFTxcpx6WcDtjhvIUMJsTRqs26bYzHns+oqOfBs0yC9lTn8shc //xX51tqbtgbTs5rKQxcbiwLhkZBK3pJ/Ub4rgbrgqqiKKN7Ciea9yPajjZI/joJyMdG itGgOAvRSiWodyuOhGXwA6YMVXcarSdTQ2jPB+v02eIfY3NmmNvBJ5UjAMdtgpG4i1cb gCBC3GhBIdkwpDyYkkJ+5NFEKW3B1vO3VAm4/WjX0OVogPmHP2sSFah7+L268qUqS/zW Q2sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=cdNFOd7zQsAnR9pP9FzvoRQoGQj1w1WjpRlr+NKG8I4=; b=lLB4TFplVfXtU2K/eYuGIKzkhaDPQpIEXn2dNB+MbJmxK10hOO4Rn1C4MHQHxfw5tV 76Qo0ilhRE+MBFtEem+71+XWUC46at5Rw04J1h3rreIDS9qQcsddHdL77R2vqu945AGm ijulK1a/PS+QwpzxlrZIBfNDoy6ZnA/8BGhpzgdM52QV8mhoP/1F7q/mPpe0ReEXtgeE RKfeyEX01lLIBYw1JyaS0bEZRA1CxW7fwQazqR9rwMNU8U2zcPwKG92QFThqxW0j9Xd7 Ya8hGDyQk5XY+9GnGnqd9CEQmEz0p2NTqspdInd6oK341Avx/1Lz3a7gXcrzMgo3PN0s FHyg== X-Gm-Message-State: APjAAAVyuj3h3V1lwvH6quzZZ6QKyEA4TG0jvtbyPk1db7kXw/gbuik2 RF6iO/lpkYjViI/gxUU57jU= X-Google-Smtp-Source: APXvYqzCzgbD3N2hdYM+1wfknOYmMqdKA4ov+/2gSkX376GahrsHfZuHHwZbYv/LoGUz4G9alDNbJA== X-Received: by 2002:adf:ee50:: with SMTP id w16mr1905223wro.93.1568706765280; Tue, 17 Sep 2019 00:52:45 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id n2sm1349204wmc.1.2019.09.17.00.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 00:52:44 -0700 (PDT) Date: Tue, 17 Sep 2019 09:52:42 +0200 From: Ingo Molnar To: Randy Dunlap Cc: Mark Brown , Linux Next Mailing List , Linux Kernel Mailing List , Ingo Molnar , Peter Zijlstra Subject: Re: linux-next: Tree for Sep 16 (kernel/sched/core.c) Message-ID: <20190917075242.GB49590@gmail.com> References: <20190916223850.GQ4352@sirena.co.uk> <1898d3c9-1997-17ce-a022-a5e28c8dc115@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1898d3c9-1997-17ce-a022-a5e28c8dc115@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org * Randy Dunlap wrote: > On 9/16/19 3:38 PM, Mark Brown wrote: > > Hi all, > > > > Changes since 20190915: > > > > on x86_64: > > when CONFIG_CGROUPS is not set: > > CC kernel/sched/core.o > ../kernel/sched/core.c: In function ‘uclamp_update_active_tasks’: > ../kernel/sched/core.c:1081:23: error: storage size of ‘it’ isn’t known > struct css_task_iter it; > ^~ > CC kernel/printk/printk_safe.o > ../kernel/sched/core.c:1084:2: error: implicit declaration of function ‘css_task_iter_start’; did you mean ‘__sg_page_iter_start’? [-Werror=implicit-function-declaration] > css_task_iter_start(css, 0, &it); > ^~~~~~~~~~~~~~~~~~~ > __sg_page_iter_start > ../kernel/sched/core.c:1085:14: error: implicit declaration of function ‘css_task_iter_next’; did you mean ‘__sg_page_iter_next’? [-Werror=implicit-function-declaration] > while ((p = css_task_iter_next(&it))) { > ^~~~~~~~~~~~~~~~~~ > __sg_page_iter_next > ../kernel/sched/core.c:1091:2: error: implicit declaration of function ‘css_task_iter_end’; did you mean ‘get_task_cred’? [-Werror=implicit-function-declaration] > css_task_iter_end(&it); > ^~~~~~~~~~~~~~~~~ > get_task_cred > ../kernel/sched/core.c:1081:23: warning: unused variable ‘it’ [-Wunused-variable] > struct css_task_iter it; > ^~ > I cannot reproduce this build failue: I took Linus's latest which has all the -next scheduler commits included (ad062195731b), and an x86-64 "make defconfig" and a disabling of CONFIG_CGROUPS still resuls in a kernel that builds fine. Thanks, Ingo