Re: perf build failed on linux -next on i386 build

[Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>]

Em Fri, Sep 27, 2019 at 02:05:32AM +0530, Naresh Kamboju escreveu:
> On Thu, 26 Sep 2019 at 23:06, Arnaldo Carvalho de Melo
> <arnaldo.melo@gmail.com> wrote:
> >
> > Em Thu, Sep 26, 2019 at 10:59:41PM +0530, Naresh Kamboju escreveu:
> > > perf build failed on linux -next on i386 build
> > >
> > > build error:
> > > perf-in.o: In function `libunwind__x86_reg_id':
> > > tools/perf/util/libunwind/../../arch/x86/util/unwind-libunwind.c:109:
> > > undefined reference to `pr_err'
> > > tools/perf/util/libunwind/../../arch/x86/util/unwind-libunwind.c:109:
> > > undefined reference to `pr_err'
> >
> > Can you try with the following patch?
> 
> Thanks for the patch.
> After applying this below patch build completes.

Thanks for the report and for testing it, appreciated,

- Arnaldo
 
> 
> >
> >
> > diff --git a/tools/perf/arch/x86/util/unwind-libunwind.c b/tools/perf/arch/x86/util/unwind-libunwind.c
> > index 05920e3edf7a..47357973b55b 100644
> > --- a/tools/perf/arch/x86/util/unwind-libunwind.c
> > +++ b/tools/perf/arch/x86/util/unwind-libunwind.c
> > @@ -1,11 +1,11 @@
> >  // SPDX-License-Identifier: GPL-2.0
> >
> >  #include <errno.h>
> > +#include "../../util/debug.h"
> >  #ifndef REMOTE_UNWIND_LIBUNWIND
> >  #include <libunwind.h>
> >  #include "perf_regs.h"
> >  #include "../../util/unwind.h"
> > -#include "../../util/debug.h"
> >  #endif
> >
> >  #ifdef HAVE_ARCH_X86_64_SUPPORT
> 
> - Naresh

-- 

- Arnaldo