From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF00FA372A for ; Wed, 16 Oct 2019 09:33:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E96D21848 for ; Wed, 16 Oct 2019 09:33:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389676AbfJPJdn (ORCPT ); Wed, 16 Oct 2019 05:33:43 -0400 Received: from mga17.intel.com ([192.55.52.151]:25194 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388426AbfJPJdm (ORCPT ); Wed, 16 Oct 2019 05:33:42 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2019 02:33:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,303,1566889200"; d="scan'208";a="200006317" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006.jf.intel.com with ESMTP; 16 Oct 2019 02:33:40 -0700 Received: from andy by smile with local (Exim 4.92.2) (envelope-from ) id 1iKfgZ-0008F9-Hq; Wed, 16 Oct 2019 12:33:39 +0300 Date: Wed, 16 Oct 2019 12:33:39 +0300 From: Andy Shevchenko To: Geert Uytterhoeven Cc: "Rafael J. Wysocki" , Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Mika Westerberg Subject: Re: linux-next: build failure after merge of the pm tree (Was: linux-next: build warning after merge of the pm tree) Message-ID: <20191016093339.GU32742@smile.fi.intel.com> References: <20191015100855.31b8a3d5@canb.auug.org.au> <20191015101650.2a1541af@canb.auug.org.au> <4823987.OjxUhv8yZC@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Wed, Oct 16, 2019 at 11:15:44AM +0200, Geert Uytterhoeven wrote: > On Tue, Oct 15, 2019 at 1:27 PM Rafael J. Wysocki wrote: > > On Tuesday, October 15, 2019 1:16:50 AM CEST Stephen Rothwell wrote: > > > On Tue, 15 Oct 2019 10:08:55 +1100 Stephen Rothwell = > > > wrote: > > > This became a build failure for the powerpc ppc64_allmodconfig build: > > > > > > In file included from include/linux/i2c.h:13, > > > from arch/powerpc/platforms/pasemi/misc.c:14: > > > include/linux/acpi.h:682:31: error: 'struct acpi_device' declared inside pa= > > > rameter list will not be visible outside of this definition or declaration = > > > [-Werror] > > > 682 | acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, = > > > const char *uid2) > > > | ^~~~~~~~~~~ > > > cc1: all warnings being treated as errors > > > > > > (and many more) > > > > > > I have used the pm tree from next-20191014 for today. > > > > So this looks weird, because there is an acpi_dev_put() stub in > > include/linux/acpi.h too in the same #else block and it takes a > > (struct acpi_device *) pointer too and it has not been touched by > > the commit in question. So why has it built successfully so far? > > Looks like that never warned because acpi_dev_put() is located after > > static inline struct acpi_device * > acpi_dev_get_first_match_dev(const char *hid, const char *uid, s64 hrv) > { > return NULL; > } > > Moving acpi_dev_hid_uid_match() down gets rid of the warning, too. Sounds like a compiler bug. It thinks that struct acpi_device * is defined as function prototype? -- With Best Regards, Andy Shevchenko