From: coverity-bot <keescook@chromium.org>
To: Sasha Neftin <sasha.neftin@intel.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Aaron Brown <aaron.f.brown@intel.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: igc_hash_mc_addr(): Integer handling issues
Date: Mon, 28 Oct 2019 16:06:15 -0700 [thread overview]
Message-ID: <201910281606.99B58CD542@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20191025 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
7f839684c5c4 ("igc: Add set_rx_mode support")
Coverity reported the following:
*** CID 1487361: Integer handling issues (BAD_SHIFT)
/drivers/net/ethernet/intel/igc/igc_mac.c: 851 in igc_hash_mc_addr()
845 break;
846 case 3:
847 bit_shift += 4;
848 break;
849 }
850
vvv CID 1487361: Integer handling issues (BAD_SHIFT)
vvv In expression "mc_addr[4] >> 8 - bit_shift", right shifting "mc_addr[4]" by more than 7 bits always yields zero. The shift amount, "8 - bit_shift", is 8.
851 hash_value = hash_mask & (((mc_addr[4] >> (8 - bit_shift)) |
852 (((u16)mc_addr[5]) << bit_shift)));
853
854 return hash_value;
855 }
856
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include:
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487361 ("Integer handling issues")
Fixes: 7f839684c5c4 ("igc: Add set_rx_mode support")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2019-10-28 23:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 23:06 coverity-bot [this message]
2019-10-30 16:17 ` Coverity: igc_hash_mc_addr(): Integer handling issues Neftin, Sasha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910281606.99B58CD542@keescook \
--to=keescook@chromium.org \
--cc=aaron.f.brown@intel.com \
--cc=gustavo@embeddedor.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-next@vger.kernel.org \
--cc=sasha.neftin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox