From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E366CA9EB5 for ; Mon, 4 Nov 2019 17:38:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E90E620869 for ; Mon, 4 Nov 2019 17:38:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="B5yBjbM7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728940AbfKDRiv (ORCPT ); Mon, 4 Nov 2019 12:38:51 -0500 Received: from mail-pf1-f177.google.com ([209.85.210.177]:39617 "EHLO mail-pf1-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728064AbfKDRiv (ORCPT ); Mon, 4 Nov 2019 12:38:51 -0500 Received: by mail-pf1-f177.google.com with SMTP id x28so9518355pfo.6 for ; Mon, 04 Nov 2019 09:38:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:date:to:cc:subject:message-id:mime-version:content-disposition; bh=skTQ/Ow6kKlSIDT7ksT48roeWn0HcwjVIqserZjjZYE=; b=B5yBjbM71ec/8gchKsEwqBJfZHWki/DEIzpWChKyVbStKlMBuHqA2fm36KyXloHBqP Lrs2FoBecTWrqqks1fCeIXBT/lnYIUJPXdngBSHsFxEaKvuYTmgMEdB8P3MksFlHkiBY WJrAGKHSB9KbvAl6cqgMMlvLoNS3AJs8MygMY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:mime-version :content-disposition; bh=skTQ/Ow6kKlSIDT7ksT48roeWn0HcwjVIqserZjjZYE=; b=bELglXjsWf2Urw62qAtbJNWDt4dkIm4Ma8jtd/iVZ+LKc5PTB8h5m8Q/yrzlbX/jAi DZCxWQCmY4jIYFZYtBcviDpFBIci0Mg7ZdfOGAMBVBV2iBA5Zi3/JhnWoVgFuBIkrFe5 oc0TfUAZ3BGraV2mB09En2gognE4vPWkDWn2wVTJU0BTPWbsdq0dZIGZ/sNTEqoBzuMs UhZ9EzWGEzhS8ytsiEPHwrolj/zk/UE4NJGQ1++cSHdL3TMFwUrjb6YASc25hW08X+JC ZJ0tsbHU40cQx92XEXYC1PtENwQChIxcfOukKNSaROo3LrGAhIxTjxUt0EE0NWLyil5w DT+w== X-Gm-Message-State: APjAAAXo7YQjSTfFjU4EqArGvclEpxQHEjyM8ipQnYjj30A2wF9ynWGx VvcNhgHWvErmXRCnsAdPwYcMheUeYOQ= X-Google-Smtp-Source: APXvYqw1cFXaBng945ztUfjuHbesJTyoTFjETSJvMIMQrdDI0y6hYHT+/BpaT+fdqJ5y9oNZxJUorA== X-Received: by 2002:a17:90a:2385:: with SMTP id g5mr332379pje.117.1572889130522; Mon, 04 Nov 2019 09:38:50 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m68sm16252888pfb.122.2019.11.04.09.38.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 09:38:49 -0800 (PST) From: coverity-bot X-Google-Original-From: coverity-bot Date: Mon, 4 Nov 2019 09:38:48 -0800 To: Ajay Singh Cc: Greg Kroah-Hartman , "Gustavo A. R. Silva" , linux-next@vger.kernel.org Subject: Coverity: wilc_parse_join_bss_param(): Memory - illegal accesses Message-ID: <201911040938.57CCE1B@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org Hello! This is an experimental automated report about issues detected by Coverity from a scan of next-20191031 as part of the linux-next weekly scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lines of code (noted below) that were touched by recent commits: 4e0b0f42c9c7 ("staging: wilc1000: use struct to pack join parameters for FW") Coverity reported the following: *** CID 1487400: Memory - illegal accesses (OVERRUN) /drivers/staging/wilc1000/wilc_hif.c: 496 in wilc_parse_join_bss_param() 490 if (supp_rates_ie) { 491 if (supp_rates_ie[1] > (WILC_MAX_RATES_SUPPORTED - rates_len)) 492 param->supp_rates[0] = WILC_MAX_RATES_SUPPORTED; 493 else 494 param->supp_rates[0] += supp_rates_ie[1]; 495 vvv CID 1487400: Memory - illegal accesses (OVERRUN) vvv Overrunning array of 13 bytes at byte offset 13 by dereferencing pointer "¶m->supp_rates[rates_len + 1]". [Note: The source code implementation of the function has been overridden by a builtin model.] 496 memcpy(¶m->supp_rates[rates_len + 1], supp_rates_ie + 2, 497 (param->supp_rates[0] - rates_len)); 498 } 499 500 ht_ie = cfg80211_find_ie(WLAN_EID_HT_CAPABILITY, ies->data, ies->len); 501 if (ht_ie) If this is a false positive, please let us know so we can mark it as such, or teach the Coverity rules to be smarter. If not, please make sure fixes get into linux-next. :) For patches fixing this, please include these lines (but double-check the "Fixes" first): Reported-by: coverity-bot Addresses-Coverity-ID: 1487400 ("Memory - illegal accesses") Fixes: 4e0b0f42c9c7 ("staging: wilc1000: use struct to pack join parameters for FW") Thanks for your attention! -- Coverity-bot