linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: coverity-bot <keescook@chromium.org>
To: Lyude Paul <lyude@redhat.com>
Cc: Sean Paul <sean@poorly.run>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	linux-next@vger.kernel.org
Subject: Coverity: drm_dp_mst_process_up_req(): Null pointer dereferences
Date: Mon, 4 Nov 2019 09:42:51 -0800	[thread overview]
Message-ID: <201911040942.CA1A7EE8@keescook> (raw)

Hello!

This is an experimental automated report about issues detected by Coverity
from a scan of next-20191031 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:

9408cc94eb04 ("drm/dp_mst: Handle UP requests asynchronously")

Coverity reported the following:

*** CID 1487392:  Null pointer dereferences  (FORWARD_NULL)
/drivers/gpu/drm/drm_dp_mst_topology.c: 3710 in drm_dp_mst_process_up_req()
3704
3705     		if (msg->req_type == DP_CONNECTION_STATUS_NOTIFY)
3706     			guid = msg->u.conn_stat.guid;
3707     		else if (msg->req_type == DP_RESOURCE_STATUS_NOTIFY)
3708     			guid = msg->u.resource_stat.guid;
3709
vvv     CID 1487392:  Null pointer dereferences  (FORWARD_NULL)
vvv     Passing null pointer "guid" to "drm_dp_get_mst_branch_device_by_guid", which dereferences it.
3710     		mstb = drm_dp_get_mst_branch_device_by_guid(mgr, guid);
3711     	} else {
3712     		mstb = drm_dp_get_mst_branch_device(mgr, hdr->lct, hdr->rad);
3713     	}
3714
3715     	if (!mstb) {

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1487392 ("Null pointer dereferences")
Fixes: 9408cc94eb04 ("drm/dp_mst: Handle UP requests asynchronously")


Thanks for your attention!

-- 
Coverity-bot

                 reply	other threads:[~2019-11-04 17:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201911040942.CA1A7EE8@keescook \
    --to=keescook@chromium.org \
    --cc=gustavo@embeddedor.com \
    --cc=linux-next@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).