linux-next: build failure after merge of the sound-asoc-fixes tree

linux-next: build failure after merge of the sound-asoc-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

Hi all,

After merging the sound-asoc-fixes tree, today's linux-next build
(x86_64 allmodconfig) failed like this:

sound/soc/sof/sof-pci-dev.c:116:15: error: 'snd_soc_acpi_intel_cfl_machines' undeclared here (not in a function); did you mean 'snd_soc_acpi_intel_cnl_machines'?
  116 |  .machines  = snd_soc_acpi_intel_cfl_machines,
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |               snd_soc_acpi_intel_cnl_machines
sound/soc/sof/sof-pci-dev.c:136:15: error: 'snd_soc_acpi_intel_cml_machines' undeclared here (not in a function); did you mean 'snd_soc_acpi_intel_cnl_machines'?
  136 |  .machines  = snd_soc_acpi_intel_cml_machines,
      |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |               snd_soc_acpi_intel_cnl_machines

Caused by commit

  1d3e9077307f ("ASoC: SOF: Intel: Fix CFL and CML FW nocodec binary names.")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the sound-asoc-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

Hi all,

On Wed, 13 Nov 2019 08:10:35 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the sound-asoc-fixes tree, today's linux-next build
> (x86_64 allmodconfig) failed like this:
> 
> sound/soc/sof/sof-pci-dev.c:116:15: error: 'snd_soc_acpi_intel_cfl_machines' undeclared here (not in a function); did you mean 'snd_soc_acpi_intel_cnl_machines'?
>   116 |  .machines  = snd_soc_acpi_intel_cfl_machines,
>       |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |               snd_soc_acpi_intel_cnl_machines
> sound/soc/sof/sof-pci-dev.c:136:15: error: 'snd_soc_acpi_intel_cml_machines' undeclared here (not in a function); did you mean 'snd_soc_acpi_intel_cnl_machines'?
>   136 |  .machines  = snd_soc_acpi_intel_cml_machines,
>       |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |               snd_soc_acpi_intel_cnl_machines
> 
> Caused by commit
> 
>   1d3e9077307f ("ASoC: SOF: Intel: Fix CFL and CML FW nocodec binary names.")
> 
> I have reverted that commit for today.

I am still reverting that commit.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the sound-asoc-fixes tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

On Fri, Nov 15, 2019 at 09:34:10AM +1100, Stephen Rothwell wrote:
> On Wed, 13 Nov 2019 08:10:35 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> > Caused by commit

> >   1d3e9077307f ("ASoC: SOF: Intel: Fix CFL and CML FW nocodec binary names.")

> > I have reverted that commit for today.

> I am still reverting that commit.

I've reverted the commit, I was a bit disappointed that none of the
Intel people responded but I see you didn't CC Pierre who sent the
commit so he won't have seen your report - I missed that due to the CC
to Liam who was also in the chain.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the sound-asoc-fixes tree

[Pierre-Louis Bossart]

On 11/18/19 9:58 AM, Mark Brown wrote:
> On Fri, Nov 15, 2019 at 09:34:10AM +1100, Stephen Rothwell wrote:
>> On Wed, 13 Nov 2019 08:10:35 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> 
>>> Caused by commit
> 
>>>    1d3e9077307f ("ASoC: SOF: Intel: Fix CFL and CML FW nocodec binary names.")
> 
>>> I have reverted that commit for today.
> 
>> I am still reverting that commit.
> 
> I've reverted the commit, I was a bit disappointed that none of the
> Intel people responded but I see you didn't CC Pierre who sent the
> commit so he won't have seen your report - I missed that due to the CC
> to Liam who was also in the chain.

Sorry about that, the use of 'Fix' in the commit message might have 
misled Mark.
If you CC: me and also CC: alsa-devel you should get an answer without 
delay. I only noticed the issue this morning with kbuild reports.

Re: linux-next: build failure after merge of the sound-asoc-fixes tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

On Mon, Nov 18, 2019 at 10:47:01AM -0600, Pierre-Louis Bossart wrote:
> On 11/18/19 9:58 AM, Mark Brown wrote:

> > I've reverted the commit, I was a bit disappointed that none of the
> > Intel people responded but I see you didn't CC Pierre who sent the
> > commit so he won't have seen your report - I missed that due to the CC
> > to Liam who was also in the chain.

> Sorry about that, the use of 'Fix' in the commit message might have misled
> Mark.
> If you CC: me and also CC: alsa-devel you should get an answer without
> delay. I only noticed the issue this morning with kbuild reports.

Yeah, sorry about that - like I say when I looked at the mail I saw the
CC to Liam and didn't twig that it was only to tree maintainers not to
commit authors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the sound-asoc-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 440 bytes --]

Hi Mark,

On Mon, 18 Nov 2019 15:58:52 +0000 Mark Brown <broonie@kernel.org> wrote:
>
> I've reverted the commit, I was a bit disappointed that none of the
> Intel people responded but I see you didn't CC Pierre who sent the
> commit so he won't have seen your report - I missed that due to the CC
> to Liam who was also in the chain.

Sorry about that, I usually manage to CC everyone involved.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the sound-asoc-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 968 bytes --]

Hi all,

After merging the sound-asoc-fixes tree, today's linux-next build
(powerpc allyesconfig) failed like this:

sound/soc/codecs/cs35l41.c: In function 'cs35l41_acpi_get_name':
sound/soc/codecs/cs35l41.c:1166:31: error: implicit declaration of function 'acpi_device_hid'; did you mean 'acpi_device_handle'? [-Wimplicit-function-declaration]
 1166 |                         hid = acpi_device_hid(adev);
      |                               ^~~~~~~~~~~~~~~
      |                               acpi_device_handle
sound/soc/codecs/cs35l41.c:1166:29: error: assignment to 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
 1166 |                         hid = acpi_device_hid(adev);
      |                             ^

Caused by commit

  1d44a30ae3f9 ("ASoC: cs35l41: Fallback to using HID for system_name if no SUB is available")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the sound-asoc-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2047 bytes --]

Hi all,

After merging the sound-asoc-fixes tree, today's linux-next build
(x86_64 allmodconfig) failed like this:

sound/soc/sdw_utils/soc_sdw_utils.c:316:18: error: 'struct asoc_sdw_codec_info' has no member named 'name_prefix'
  316 |                 .name_prefix = "rt1320",
      |                  ^~~~~~~~~~~
sound/soc/sdw_utils/soc_sdw_utils.c:316:32: error: initialization of 'int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
  316 |                 .name_prefix = "rt1320",
      |                                ^~~~~~~~
sound/soc/sdw_utils/soc_sdw_utils.c:316:32: note: (near initialization for 'codec_info_list[12].version_id')
sound/soc/sdw_utils/soc_sdw_utils.c:316:32: error: initializer element is not computable at load time
sound/soc/sdw_utils/soc_sdw_utils.c:316:32: note: (near initialization for 'codec_info_list[12].version_id')
sound/soc/sdw_utils/soc_sdw_utils.c:564:18: error: 'struct asoc_sdw_codec_info' has no member named 'name_prefix'
  564 |                 .name_prefix = "AMP",
      |                  ^~~~~~~~~~~
sound/soc/sdw_utils/soc_sdw_utils.c:564:32: error: initialization of 'int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
  564 |                 .name_prefix = "AMP",
      |                                ^~~~~
sound/soc/sdw_utils/soc_sdw_utils.c:564:32: note: (near initialization for 'codec_info_list[23].version_id')
sound/soc/sdw_utils/soc_sdw_utils.c:564:32: error: initializer element is not computable at load time
sound/soc/sdw_utils/soc_sdw_utils.c:564:32: note: (near initialization for 'codec_info_list[23].version_id')

Caused by commits

  3293d3d7b088 ("ASoC: sdw_utils: add name_prefix for rt1321 part id")
  61eb4112a8fb ("ASoC: soc_sdw_utils: add cs35l57 support")

But something else has changed because 3293d3d7b088 was also in
yesterday's linux-next - which did not fail to build.

I have used the sound-asoc-fixes tree from next-20251022 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the sound-asoc-fixes tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 761 bytes --]

On Fri, Oct 24, 2025 at 10:19:31AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the sound-asoc-fixes tree, today's linux-next build
> (x86_64 allmodconfig) failed like this:
> 
> sound/soc/sdw_utils/soc_sdw_utils.c:316:18: error: 'struct asoc_sdw_codec_info' has no member named 'name_prefix'
>   316 |                 .name_prefix = "rt1320",
>       |                  ^~~~~~~~~~~
> sound/soc/sdw_utils/soc_sdw_utils.c:316:32: error: initialization of 'int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
>   316 |                 .name_prefix = "rt1320",
>       |                                ^~~~~~~~

And I do x86 allmodconfig builds which should stop something that breaks
getting published...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the sound-asoc-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

Hi Mark,

On Fri, 24 Oct 2025 00:49:11 +0100 Mark Brown <broonie@kernel.org> wrote:
>
> On Fri, Oct 24, 2025 at 10:19:31AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the sound-asoc-fixes tree, today's linux-next build
> > (x86_64 allmodconfig) failed like this:
> > 
> > sound/soc/sdw_utils/soc_sdw_utils.c:316:18: error: 'struct asoc_sdw_codec_info' has no member named 'name_prefix'
> >   316 |                 .name_prefix = "rt1320",
> >       |                  ^~~~~~~~~~~
> > sound/soc/sdw_utils/soc_sdw_utils.c:316:32: error: initialization of 'int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
> >   316 |                 .name_prefix = "rt1320",
> >       |                                ^~~~~~~~  
> 
> And I do x86 allmodconfig builds which should stop something that breaks
> getting published...

Yeah, so there must be an interaction with something merged before your
tree ... but I couldn't find anything obvious, sorry.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the sound-asoc-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]

Hi all,

On Fri, 24 Oct 2025 12:09:20 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 24 Oct 2025 00:49:11 +0100 Mark Brown <broonie@kernel.org> wrote:
> >
> > On Fri, Oct 24, 2025 at 10:19:31AM +1100, Stephen Rothwell wrote:  
> > > Hi all,
> > > 
> > > After merging the sound-asoc-fixes tree, today's linux-next build
> > > (x86_64 allmodconfig) failed like this:
> > > 
> > > sound/soc/sdw_utils/soc_sdw_utils.c:316:18: error: 'struct asoc_sdw_codec_info' has no member named 'name_prefix'
> > >   316 |                 .name_prefix = "rt1320",
> > >       |                  ^~~~~~~~~~~
> > > sound/soc/sdw_utils/soc_sdw_utils.c:316:32: error: initialization of 'int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
> > >   316 |                 .name_prefix = "rt1320",
> > >       |                                ^~~~~~~~    
> > 
> > And I do x86 allmodconfig builds which should stop something that breaks
> > getting published...  
> 
> Yeah, so there must be an interaction with something merged before your
> tree ... but I couldn't find anything obvious, sorry.

I am still getting this failure.  I cannot find anything that would
have interacted with this addition of name_prefix.  I can only
speculate that maybe this file was not built in the past for an x86_64
allmodconfig (i.e. some KCONFIG change) or an update to an include file
has messed being committed.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the sound-asoc-fixes tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1841 bytes --]

Hi all,

On Tue, 28 Oct 2025 09:34:11 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Fri, 24 Oct 2025 12:09:20 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Fri, 24 Oct 2025 00:49:11 +0100 Mark Brown <broonie@kernel.org> wrote:  
> > >
> > > On Fri, Oct 24, 2025 at 10:19:31AM +1100, Stephen Rothwell wrote:    
> > > > Hi all,
> > > > 
> > > > After merging the sound-asoc-fixes tree, today's linux-next build
> > > > (x86_64 allmodconfig) failed like this:
> > > > 
> > > > sound/soc/sdw_utils/soc_sdw_utils.c:316:18: error: 'struct asoc_sdw_codec_info' has no member named 'name_prefix'
> > > >   316 |                 .name_prefix = "rt1320",
> > > >       |                  ^~~~~~~~~~~
> > > > sound/soc/sdw_utils/soc_sdw_utils.c:316:32: error: initialization of 'int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
> > > >   316 |                 .name_prefix = "rt1320",
> > > >       |                                ^~~~~~~~      
> > > 
> > > And I do x86 allmodconfig builds which should stop something that breaks
> > > getting published...    
> > 
> > Yeah, so there must be an interaction with something merged before your
> > tree ... but I couldn't find anything obvious, sorry.  
> 
> I am still getting this failure.  I cannot find anything that would
> have interacted with this addition of name_prefix.  I can only
> speculate that maybe this file was not built in the past for an x86_64
> allmodconfig (i.e. some KCONFIG change) or an update to an include file
> has messed being committed.

Found it!  There is commit

  ea9771390378 ("ASoC: soc_sdw_utils: add name_prefix to asoc_sdw_codec_info struct")

in the sound-asoc tree (which is not merged into linux-next until much
later).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the sound-asoc-fixes tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

On Tue, Oct 28, 2025 at 09:37:25AM +1100, Stephen Rothwell wrote:
> On Tue, 28 Oct 2025 09:34:11 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> > I am still getting this failure.  I cannot find anything that would
> > have interacted with this addition of name_prefix.  I can only
> > speculate that maybe this file was not built in the past for an x86_64
> > allmodconfig (i.e. some KCONFIG change) or an update to an include file
> > has messed being committed.

> Found it!  There is commit

>   ea9771390378 ("ASoC: soc_sdw_utils: add name_prefix to asoc_sdw_codec_info struct")

> in the sound-asoc tree (which is not merged into linux-next until much
> later).

Yes, I know that.  What was bothering me was why it wasn't showing up in
my build tests which normally include allmodconfig.  I just realised
that I'm still suppressing those tests because mainline failed to build
an allmodconfig due to:

/build/stage/linux/drivers/dma/mmp_pdma.c:1188:14: error: shift count >= width o
f type [-Werror,-Wshift-count-overflow]
 1188 |         .dma_mask = DMA_BIT_MASK(64),   /* force 64-bit DMA addr capabil
ity */
      |                     ^~~~~~~~~~~~~~~~
/build/stage/linux/include/linux/dma-mapping.h:93:54: note: expanded from macro 
'DMA_BIT_MASK'
   93 | #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
      |                                                      ^ ~~~

and never gets far enough into the build to show anything else.  I think
that subsequently got fixed in mainline but I didn't merge up yet.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]