linux-next: build failure after merge of the keys tree

Stephen Rothwell
2019-08-16T05:04:10Z

[-- Attachment #1: Type: text/plain, Size: 1737 bytes --]

Hi all,

After merging the keys tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/md/dm-verity-verify-sig.c: In function 'verity_verify_get_sig_from_key':
drivers/md/dm-verity-verify-sig.c:38:8: error: too few arguments to function 'request_key'
key = request_key(&key_type_user,
^~~~~~~~~~~
In file included from include/keys/user-type.h:11,
from drivers/md/dm-verity-verify-sig.c:10:
include/linux/key.h:318:27: note: declared here
static inline struct key *request_key(struct key_type *type,
^~~~~~~~~~~

Caused by commit

f802f2b3a991 ("keys: Replace uid/gid/perm permissions checking with an ACL")

interacting with commit

644332ceab35 ("dm verity: add root hash pkcs#7 signature verification")

from the device-mapper tree.

I applied the following merge resolution patch.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 16 Aug 2019 15:00:15 +1000
Subject: [PATCH] dm verity: merge fix for "keys: Replace uid/gid/perm
permissions checking with an ACL"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/md/dm-verity-verify-sig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-verity-verify-sig.c b/drivers/md/dm-verity-verify-sig.c
index 614e43db93aa..2ca162d43fe6 100644
--- a/drivers/md/dm-verity-verify-sig.c
+++ b/drivers/md/dm-verity-verify-sig.c
@@ -36,7 +36,7 @@ static int verity_verify_get_sig_from_key(const char *key_desc,
int ret = 0;

key = request_key(&key_type_user,
- key_desc, NULL);
+ key_desc, NULL, NULL);
if (IS_ERR(key))
return PTR_ERR(key);

--
2.20.1