From: David Sterba <dsterba@suse.cz>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: David Sterba <dsterba@suse.cz>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nikolay Borisov <nborisov@suse.com>
Subject: Re: linux-next: build warnings after merge of the btrfs tree
Date: Fri, 17 Jan 2020 17:24:09 +0100 [thread overview]
Message-ID: <20200117162409.GL3929@twin.jikos.cz> (raw)
In-Reply-To: <20200115093004.1a4a6794@canb.auug.org.au>
On Wed, Jan 15, 2020 at 09:30:04AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the btrfs tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these warnings:
>
> fs/btrfs/block-group.c: In function 'exclude_super_stripes':
> fs/btrfs/block-group.c:1706:5: warning: 'logical' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 1706 | kfree(logical);
> | ^~~~~~~~~~~~~~
> fs/btrfs/block-group.c:1691:20: warning: 'stripe_len' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 1691 | if (logical[nr] + stripe_len <= cache->start)
> | ~~~~~~~~~~~~^~~~~~~~~~~~
>
> Introduced by commit
>
> 767f58cdaf20 ("btrfs: Refactor btrfs_rmap_block to improve readability")
>
> btrfs_rmap_block() returns zero even if its output arguments are not
> assigned to ... maybe the final "return 0" should be "return ret"?
Yes that's it, thanks. Updated for-next branch pushed.
next prev parent reply other threads:[~2020-01-17 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 22:30 linux-next: build warnings after merge of the btrfs tree Stephen Rothwell
2020-01-17 16:24 ` David Sterba [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-27 1:36 Stephen Rothwell
2023-09-12 0:46 Stephen Rothwell
2023-09-12 11:20 ` David Sterba
2023-09-12 12:20 ` Stephen Rothwell
2023-09-20 3:16 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117162409.GL3929@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox