From: Will Deacon <will@kernel.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>,
anshuman.khandual@arm.com, catalin.marinas@arm.com
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
rppt@linux.ibm.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Arnd Bergmann <arnd@arndb.de>,
lkft-triage@lists.linaro.org,
Andrew Morton <akpm@linux-foundation.org>,
suzuki.poulose@arm.com, Anders Roxell <anders.roxell@linaro.org>
Subject: Re: Linux-next-20200302: arm64 build failed
Date: Mon, 2 Mar 2020 10:47:27 +0000 [thread overview]
Message-ID: <20200302104726.GA7995@willie-the-truck> (raw)
In-Reply-To: <CA+G9fYtAM-m0jygud+i0ymU+XknV9_GcAbDQChiD2NZjvQ+D3w@mail.gmail.com>
[+Anshuman and Catalin]
On Mon, Mar 02, 2020 at 01:58:26PM +0530, Naresh Kamboju wrote:
> Linux-Next 20200302 arm64 build failed due to below errors,
> Suspecting patch causing this build break.
>
> 87d900aef3e2 arm/arm64: add support for folded p4d page tables
>
> Error log,
> -------------
> arch/arm64/mm/mmu.c: In function 'unmap_hotplug_pud_range':
> include/linux/compiler.h:284:1: error: incompatible type for argument
> 1 of 'p4d_page_paddr'
> ({ \
> ^
> arch/arm64/include/asm/memory.h:270:45: note: in definition of macro
> '__phys_to_virt'
> #define __phys_to_virt(x) ((unsigned long)((x) - physvirt_offset))
> ^
> arch/arm64/include/asm/pgtable.h:629:42: note: in expansion of macro '__va'
> #define pud_offset(dir, addr) ((pud_t *)__va(pud_offset_phys((dir), (addr))))
> ^~~~
> include/linux/compiler.h:293:22: note: in expansion of macro '__READ_ONCE'
> #define READ_ONCE(x) __READ_ONCE(x, 1)
> ^~~~~~~~~~~
> arch/arm64/include/asm/pgtable.h:628:52: note: in expansion of macro 'READ_ONCE'
> #define pud_offset_phys(dir, addr) (p4d_page_paddr(READ_ONCE(*(dir)))
> + pud_index(addr) * sizeof(pud_t))
> ^~~~~~~~~
> arch/arm64/include/asm/pgtable.h:629:47: note: in expansion of macro
> 'pud_offset_phys'
> #define pud_offset(dir, addr) ((pud_t *)__va(pud_offset_phys((dir), (addr))))
> ^~~~~~~~~~~~~~~
> arch/arm64/mm/mmu.c:827:10: note: in expansion of macro 'pud_offset'
> pudp = pud_offset(pgdp, addr);
> ^~~~~~~~~~
Looks like we need an implementation of unmap_hotplug_p4d_range() to
walk the dummy p4d level. Unfortunately, we don't have the folded p4d
patches in the arm64 tree so we'll either need a common branch or the
hotplug patches will need to be dropped for the moment.
Will
next prev parent reply other threads:[~2020-03-02 10:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 8:28 Linux-next-20200302: arm64 build failed Naresh Kamboju
2020-03-02 10:47 ` Will Deacon [this message]
2020-03-02 13:48 ` Anshuman Khandual
2020-03-02 13:54 ` Mike Rapoport
2020-03-02 17:45 ` Catalin Marinas
2020-03-02 22:24 ` Andrew Morton
2020-03-03 4:04 ` Anshuman Khandual
2020-03-03 16:28 ` Catalin Marinas
2020-03-04 2:26 ` Anshuman Khandual
2020-03-04 4:32 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302104726.GA7995@willie-the-truck \
--to=will@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=anshuman.khandual@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=rppt@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox