From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B19E0C4332D for ; Thu, 19 Mar 2020 17:40:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D3892071C for ; Thu, 19 Mar 2020 17:40:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="afKhusDR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727212AbgCSRki (ORCPT ); Thu, 19 Mar 2020 13:40:38 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:47853 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727189AbgCSRkh (ORCPT ); Thu, 19 Mar 2020 13:40:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584639636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rDGB2gISJXumrloU25X+e/BYgSZE7+VD3fP0lUQQ0zM=; b=afKhusDRZv2YOBDHQP8J4oo8T4QFxH0AJPKtr18Rng3xTX2xpNe9fFZGHlC9gzh3/VXKgB 2UHtpaE8BC5qI753N2wU67+g5gcRjELbnb+M1yxAYxvagUoRMvr1e5yN/wMNymSLvXHSwU nozXsp6OCAxGjXA37HH4ChwNOpWMyIM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-259-wBhfegWhPqmK0Zf4qjgI8w-1; Thu, 19 Mar 2020 13:40:34 -0400 X-MC-Unique: wBhfegWhPqmK0Zf4qjgI8w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF7D8190A7A0; Thu, 19 Mar 2020 17:40:32 +0000 (UTC) Received: from treble (unknown [10.10.110.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 63D2760BF7; Thu, 19 Mar 2020 17:40:31 +0000 (UTC) Date: Thu, 19 Mar 2020 12:40:28 -0500 From: Josh Poimboeuf To: Peter Zijlstra Cc: Randy Dunlap , Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Kees Cook Subject: Re: linux-next: Tree for Mar 18 (objtool) Message-ID: <20200319174028.azzaisoj5gbss7zk@treble> References: <20200318220920.48df2e76@canb.auug.org.au> <20200318182352.2dgwwl4ugbwndi4x@treble> <20200318200542.GK20730@hirez.programming.kicks-ass.net> <20200319173101.wufpymi7obhqgoqd@treble> <20200319173326.oj4qs24x4ly5lrgt@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200319173326.oj4qs24x4ly5lrgt@treble> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Thu, Mar 19, 2020 at 12:33:31PM -0500, Josh Poimboeuf wrote: > On Thu, Mar 19, 2020 at 12:31:05PM -0500, Josh Poimboeuf wrote: > > ... except the __builtin_trap() UD2 seems to be coming *after* the BUG > > UD2. Could it be the BUG UD2 itself which is convincing UBSAN to add > > the __builtin_trap()? > > Actually I suspect it's the __builtin_unreachable() annotation which is > making UBSAN add the __builtin_trap()... because I don't see any double > UD2s for WARNs. Scratch that theory, removing the __builtin_unreachable() from unreachable() doesn't make the double UD2 go away. -- Josh