From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20D3EC54FCF for ; Wed, 25 Mar 2020 16:14:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08F7D20789 for ; Wed, 25 Mar 2020 16:14:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727901AbgCYQOH (ORCPT ); Wed, 25 Mar 2020 12:14:07 -0400 Received: from mga12.intel.com ([192.55.52.136]:50007 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727174AbgCYQOH (ORCPT ); Wed, 25 Mar 2020 12:14:07 -0400 IronPort-SDR: b8mTuNUUNP+XzqBeqZMRGIPT+eBg/gudpHhe9KB5USlCzEstht8eiuNexHoIdS+ZdZdrBHG6SO n98FS7rkz5KQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2020 09:14:06 -0700 IronPort-SDR: e2Ug/iZdOJlUCQRIUNttPiRngVaekzIE3L0ixyPw2HDDsCjj2pkvNXD8I7//zXaMmmVQzMAkbI cBbKIh4y4fpA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,304,1580803200"; d="scan'208";a="270854277" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.202]) by fmsmga004.fm.intel.com with ESMTP; 25 Mar 2020 09:14:06 -0700 Date: Wed, 25 Mar 2020 09:14:06 -0700 From: Sean Christopherson To: Paolo Bonzini Cc: Randy Dunlap , Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , KVM , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel Subject: Re: linux-next: Tree for Mar 25 (arch/x86/kvm/) Message-ID: <20200325161405.GG14294@linux.intel.com> References: <20200325195350.7300fee9@canb.auug.org.au> <064720eb-2147-1b92-7a62-f89d6380f40a@infradead.org> <85430f7e-93e0-3652-0705-9cf6e948a9d8@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85430f7e-93e0-3652-0705-9cf6e948a9d8@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Wed, Mar 25, 2020 at 05:08:03PM +0100, Paolo Bonzini wrote: > On 25/03/20 16:57, Randy Dunlap wrote: > >> Randy, can you test it with your compiler? > > Nope, no help. That's the wrong location. > > Need a patch for this: > >>> 24 (only showing one of them here) BUILD_BUG() errors in arch/x86/kvm/cpuid.h > >>> function __cpuid_entry_get_reg(), for the default: case. > > Doh, right. I think the only solution for that one is to degrade it to > WARN_ON(1). I reproduced the error, give me a bit to play with the code to see if the BUILD_BUG can be preserved. I'm curious as to why kvm_cpu_cap_mask() is special, and why it only fails with this config.