From: coverity-bot <keescook@chromium.org>
To: Sathish Narasimman <sathish.narasimman@intel.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Chethan T N <chethan.tumkur.narayan@intel.com>,
kbuild test robot <lkp@intel.com>,
Amit K Bag <amit.k.bag@intel.com>,
Hsin-Yu Chao <hychao@chromium.org>,
Johan Hedberg <johan.hedberg@intel.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: btusb_work(): Null pointer dereferences
Date: Mon, 6 Apr 2020 08:49:31 -0700 [thread overview]
Message-ID: <202004060849.823489FC@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20200406 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by recent commits:
baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB Endpoints")
Coverity reported the following:
*** CID 1492498: Null pointer dereferences (FORWARD_NULL)
/drivers/bluetooth/btusb.c: 1665 in btusb_work()
1659 }
1660 } else if (data->air_mode == HCI_NOTIFY_ENABLE_SCO_TRANSP) {
1661
1662 data->usb_alt6_packet_flow = true;
1663
1664 /* Check if Alt 6 is supported for Transparent audio */
vvv CID 1492498: Null pointer dereferences (FORWARD_NULL)
vvv Passing "data" to "btusb_find_altsetting", which dereferences null "data->isoc".
1665 if (btusb_find_altsetting(data, 6))
1666 new_alts = 6;
1667 else
1668 bt_dev_err(hdev, "Device does not support ALT setting 6");
1669 }
1670
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1492498 ("Null pointer dereferences")
Fixes: baac6276c0a9 ("Bluetooth: btusb: handle mSBC audio over USB Endpoints")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2020-04-06 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 15:49 coverity-bot [this message]
2020-04-07 10:54 ` Coverity: btusb_work(): Null pointer dereferences Narasimman, Sathish
2020-04-07 18:14 ` Kees Cook
2020-04-08 7:38 ` Narasimman, Sathish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202004060849.823489FC@keescook \
--to=keescook@chromium.org \
--cc=amit.k.bag@intel.com \
--cc=chethan.tumkur.narayan@intel.com \
--cc=gustavo@embeddedor.com \
--cc=hychao@chromium.org \
--cc=johan.hedberg@intel.com \
--cc=linux-next@vger.kernel.org \
--cc=lkp@intel.com \
--cc=marcel@holtmann.org \
--cc=sathish.narasimman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox