From: coverity-bot <keescook@chromium.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Jassi Brar <jaswinder.singh@linaro.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: imx_mu_scu_rx(): Memory - corruptions
Date: Mon, 13 Apr 2020 09:21:15 -0700 [thread overview]
Message-ID: <202004130921.01C9D700D@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20200413 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Thu Mar 19 15:49:52 2020 +0800
0a67003b1985 ("mailbox: imx: add SCU MU support")
Coverity reported the following:
*** CID 1461658: Memory - corruptions (OVERRUN)
/drivers/mailbox/imx-mailbox.c: 214 in imx_mu_scu_rx()
208 ret = readl_poll_timeout(priv->base + priv->dcfg->xSR, xsr,
209 xsr & IMX_MU_xSR_RFn(i % 4), 0, 100);
210 if (ret) {
211 dev_err(priv->dev, "timeout read idx %d\n", i);
212 return ret;
213 }
vvv CID 1461658: Memory - corruptions (OVERRUN)
vvv Overrunning array of 8 4-byte elements at element index 31 (byte offset 127) by dereferencing pointer "data++".
214 *data++ = imx_mu_read(priv, priv->dcfg->xRR[i % 4]);
215 }
216
217 imx_mu_xcr_rmw(priv, IMX_MU_xCR_RIEn(0), 0);
218 mbox_chan_received_data(cp->chan, (void *)&msg);
219
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1461658 ("Memory - corruptions")
Fixes: 0a67003b1985 ("mailbox: imx: add SCU MU support")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2020-04-13 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 16:21 coverity-bot [this message]
2020-04-14 3:16 ` Coverity: imx_mu_scu_rx(): Memory - corruptions Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202004130921.01C9D700D@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-next@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox