From: coverity-bot <keescook@chromium.org>
To: Brad Love <brad@nextdimension.cc>
Cc: Sean Young <sean@mess.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: m88ds3103_set_frontend(): Code maintainability issues
Date: Mon, 13 Apr 2020 09:22:22 -0700 [thread overview]
Message-ID: <202004130922.C3E42629@keescook> (raw)
Hello!
This is an experimental automated report about issues detected by Coverity
from a scan of next-20200413 as part of the linux-next weekly scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Sat Feb 1 22:48:24 2020 +0100
e6089feca460 ("media: m88ds3103: Add support for ds3103b demod")
Coverity reported the following:
*** CID 1461655: Code maintainability issues (UNUSED_VALUE)
/drivers/media/dvb-frontends/m88ds3103.c: 982 in m88ds3103_set_frontend()
976 /* enable/disable 192M LDPC clock */
977 ret = m88ds3103_update_bits(dev, 0x29, 0x10,
978 (c->delivery_system == SYS_DVBS) ? 0x10 : 0x0);
979 if (ret)
980 goto err;
981
vvv CID 1461655: Code maintainability issues (UNUSED_VALUE)
vvv Assigning value from "m88ds3103_update_bits(dev, 201, 8, 8)" to "ret" here, but that stored value is overwritten before it can be used.
982 ret = m88ds3103_update_bits(dev, 0xc9, 0x08, 0x08);
983 }
984
985 dev_dbg(&client->dev, "carrier offset=%d\n",
986 (tuner_frequency_khz - c->frequency));
987
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1461655 ("Code maintainability issues")
Fixes: e6089feca460 ("media: m88ds3103: Add support for ds3103b demod")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2020-04-13 16:22 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202004130922.C3E42629@keescook \
--to=keescook@chromium.org \
--cc=brad@nextdimension.cc \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox