From: coverity-bot <keescook@chromium.org>
To: Paul Thomas <pthomas8589@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: pca953x_gpio_get_multiple(): Uninitialized variables
Date: Fri, 17 Apr 2020 14:58:20 -0700 [thread overview]
Message-ID: <202004171458.BEA64B0CF@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20200417 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Tue Apr 14 11:28:42 2020 -0400
96d7c7b3e654 ("gpio: gpio-pca953x, Add get_multiple function")
Coverity reported the following:
*** CID 1492652: Uninitialized variables (UNINIT)
/drivers/gpio/gpio-pca953x.c: 499 in pca953x_gpio_get_multiple()
493 if (ret < 0)
494 return ret;
495 }
496 /* reg_val is relative to the last read byte,
497 * so only shift the relative bits
498 */
vvv CID 1492652: Uninitialized variables (UNINIT)
vvv Using uninitialized value "reg_val".
499 value = (reg_val >> (i % 8)) & 0x01;
500 __assign_bit(i, bits, value);
501 }
502 return ret;
503 }
504
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1492652 ("Uninitialized variables")
Fixes: 96d7c7b3e654 ("gpio: gpio-pca953x, Add get_multiple function")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2020-04-17 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 21:58 coverity-bot [this message]
2020-04-17 22:15 ` Coverity: pca953x_gpio_get_multiple(): Uninitialized variables Paul Thomas
2020-04-17 22:45 ` Kees Cook
2020-04-17 23:17 ` Paul Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202004171458.BEA64B0CF@keescook \
--to=keescook@chromium.org \
--cc=bgolaszewski@baylibre.com \
--cc=gustavo@embeddedor.com \
--cc=linus.walleij@linaro.org \
--cc=linux-next@vger.kernel.org \
--cc=pthomas8589@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox