From: coverity-bot <keescook@chromium.org>
To: Tzu-En Huang <tehuang@realtek.com>
Cc: Yan-Hsuan Chuang <yhchuang@realtek.com>,
Kalle Valo <kvalo@codeaurora.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: rtw8822c_dpk_cal_coef1(): Error handling issues
Date: Fri, 24 Apr 2020 08:26:14 -0700 [thread overview]
Message-ID: <202004240826.6E2BADAF7@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20200424 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Mon Sep 9 15:16:08 2019 +0800
5227c2ee453d ("rtw88: 8822c: add SW DPK support")
Coverity reported the following:
*** CID 1492716: Error handling issues (CHECKED_RETURN)
/drivers/net/wireless/realtek/rtw88/rtw8822c.c: 3147 in rtw8822c_dpk_cal_coef1()
3141
3142 rtw_write32_mask(rtwdev, REG_NCTL0, BIT_SUBPAGE, 0x0000000c);
3143 rtw_write32(rtwdev, REG_RXSRAM_CTL, 0x000000f0);
3144 rtw_write32(rtwdev, REG_NCTL0, 0x00001148);
3145 rtw_write32(rtwdev, REG_NCTL0, 0x00001149);
3146
vvv CID 1492716: Error handling issues (CHECKED_RETURN)
vvv Calling "check_hw_ready" without checking return value (as is done elsewhere 20 out of 21 times).
3147 check_hw_ready(rtwdev, 0x2d9c, MASKBYTE0, 0x55);
3148
3149 rtw_write8(rtwdev, 0x1b10, 0x0);
3150 rtw_write32_mask(rtwdev, REG_NCTL0, BIT_SUBPAGE, 0x0000000c);
3151
3152 for (path = 0; path < rtwdev->hal.rf_path_num; path++) {
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1492716 ("Error handling issues")
Fixes: 5227c2ee453d ("rtw88: 8822c: add SW DPK support")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2020-04-24 15:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202004240826.6E2BADAF7@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=kvalo@codeaurora.org \
--cc=linux-next@vger.kernel.org \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).