From: coverity-bot <keescook@chromium.org>
To: Yintian Tao <yttao@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: gmc_v10_0_flush_gpu_tlb_pasid(): Program hangs
Date: Fri, 24 Apr 2020 08:26:24 -0700 [thread overview]
Message-ID: <202004240826.F065651@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20200424 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
Thu Apr 23 12:05:54 2020 +0800
82478876eaac ("drm/amdgpu: protect ring overrun")
Coverity reported the following:
*** CID 1492715: Program hangs (LOCK)
/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c: 434 in gmc_v10_0_flush_gpu_tlb_pasid()
428 kiq->pmf->kiq_invalidate_tlbs(ring,
429 pasid, flush_type, all_hub);
430 r = amdgpu_fence_emit_polling(ring, &seq, MAX_KIQ_REG_WAIT);
431 if (r) {
432 amdgpu_ring_undo(ring);
433 spin_unlock(&kiq->ring_lock);
vvv CID 1492715: Program hangs (LOCK)
vvv Returning without unlocking "adev->gfx.kiq.ring_lock".
434 return -ETIME;
435 }
436
437 amdgpu_ring_commit(ring);
438 spin_unlock(&adev->gfx.kiq.ring_lock);
439 r = amdgpu_fence_wait_polling(ring, seq, adev->usec_timeout);
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1492715 ("Program hangs")
Fixes: 82478876eaac ("drm/amdgpu: protect ring overrun")
Thanks for your attention!
--
Coverity-bot
next reply other threads:[~2020-04-24 15:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 15:26 coverity-bot [this message]
2020-04-25 6:46 ` Coverity: gmc_v10_0_flush_gpu_tlb_pasid(): Program hangs Tao, Yintian
2020-04-25 12:42 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202004240826.F065651@keescook \
--to=keescook@chromium.org \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=gustavo@embeddedor.com \
--cc=linux-next@vger.kernel.org \
--cc=yttao@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox