Linux-Next discussions
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Joerg Roedel <joro@8bytes.org>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Pierre Morel <pmorel@linux.ibm.com>
Subject: linux-next: manual merge of the iommu tree with the s390 tree
Date: Thu, 7 May 2020 13:58:35 +1000	[thread overview]
Message-ID: <20200507135835.05e300b5@canb.auug.org.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1742 bytes --]

Hi all,

Today's linux-next merge of the iommu tree got a conflict in:

  drivers/iommu/s390-iommu.c

between commit:

  d08d6f5d7524 ("s390/pci: adaptation of iommu to multifunction")

from the s390 tree and commit:

  522af649e57b ("iommu/s390: Convert to probe/release_device() call-backs")

from the iommu tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc drivers/iommu/s390-iommu.c
index c60d5c776fc6,610f0828f22d..000000000000
--- a/drivers/iommu/s390-iommu.c
+++ b/drivers/iommu/s390-iommu.c
@@@ -166,23 -166,16 +166,16 @@@ static void s390_iommu_detach_device(st
  	}
  }
  
- static int s390_iommu_add_device(struct device *dev)
+ static struct iommu_device *s390_iommu_probe_device(struct device *dev)
  {
- 	struct iommu_group *group = iommu_group_get_for_dev(dev);
 -	struct zpci_dev *zdev = to_pci_dev(dev)->sysdata;
 +	struct zpci_dev *zdev = to_zpci_dev(dev);
  
- 	if (IS_ERR(group))
- 		return PTR_ERR(group);
- 
- 	iommu_group_put(group);
- 	iommu_device_link(&zdev->iommu_dev, dev);
- 
- 	return 0;
+ 	return &zdev->iommu_dev;
  }
  
- static void s390_iommu_remove_device(struct device *dev)
+ static void s390_iommu_release_device(struct device *dev)
  {
 -	struct zpci_dev *zdev = to_pci_dev(dev)->sysdata;
 +	struct zpci_dev *zdev = to_zpci_dev(dev);
  	struct iommu_domain *domain;
  
  	/*

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2020-05-07  3:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07  3:58 Stephen Rothwell [this message]
2020-05-07 11:29 ` linux-next: manual merge of the iommu tree with the s390 tree Pierre Morel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200507135835.05e300b5@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=borntraeger@de.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=pmorel@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox