From: Mark Brown <broonie@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Liam Girdwood <lgirdwood@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Linux Crypto List <linux-crypto@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: linux-next: manual merge of the sound-asoc tree with the crypto tree
Date: Tue, 12 May 2020 18:08:01 +0100 [thread overview]
Message-ID: <20200512170801.GK5110@sirena.org.uk> (raw)
In-Reply-To: <20200512163632.GA916@sol.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]
On Tue, May 12, 2020 at 09:36:32AM -0700, Eric Biggers wrote:
> On Tue, May 12, 2020 at 05:22:05PM +0100, Mark Brown wrote:
> > > from the crypto tree and commit:
> > > a1304cba816e ("ASoC: cros_ec_codec: allocate shash_desc dynamically")
> > > from the sound-asoc tree.
> I Cc'ed it to the people listed in MAINTAINERS for "CHROMEOS EC CODEC DRIVER".
> I guess wasn't enough and I should have added alsa-devel@alsa-project.org too?
Yeah, you generally need to make sure the subsystem maintainers are
included as well as individual driver maintainers.
> > That doesn't seem ideal - Eric, Herbert can we get a branch with the
> > crypto patches in them to pull into the ASoC tree or something?
> We should just drop one of the patches.
> If you just want to eliminate the compiler warning about stack usage in
> wov_hotword_model_put(), then my patch in cryptodev would be better, as it moves
> the stack allocation into another function in another file.
> Alternatively, if you actually need to reduce the total stack usage (across all
> functions), then the kmalloc() patch in sound-asoc would be better.
Well, reducing the stack usage overall seems nicer overall - heads off
future problems if the struct grows or something, and if we still end up
allocating just as much on the stack then we'll have trouble at runtime
anyway - does that make sense?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-12 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 4:49 linux-next: manual merge of the sound-asoc tree with the crypto tree Stephen Rothwell
2020-05-12 16:22 ` Mark Brown
2020-05-12 16:36 ` Eric Biggers
2020-05-12 17:08 ` Mark Brown [this message]
2020-05-12 20:08 ` Eric Biggers
2020-05-12 20:31 ` Arnd Bergmann
2020-05-14 13:21 ` Ard Biesheuvel
2020-05-13 2:52 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512170801.GK5110@sirena.org.uk \
--to=broonie@kernel.org \
--cc=arnd@arndb.de \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=lgirdwood@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox