From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EDF1C433E5 for ; Thu, 16 Jul 2020 06:24:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F76A2067D for ; Thu, 16 Jul 2020 06:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594880653; bh=Z/nrTcXcFk5J/58Hd9SKJQ2QPGf+Bc9TRddt07uYXJ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ywGWSZuIPO3H5ORSd96ZCFW+gsA7tkcOzor5OpAnqa9DaC8pEY0msiPVgXdythQDc VybMTpVU4ycGwopx55it/BsFDxda8A6INg50AJWgt1kaIFwjuQzf8jPfcFdFYIDQfU lw0iLyr47pN7/Sw46MWU2iCzqVu05lLsLAU/eO4g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727119AbgGPGYM (ORCPT ); Thu, 16 Jul 2020 02:24:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:50546 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbgGPGYL (ORCPT ); Thu, 16 Jul 2020 02:24:11 -0400 Received: from localhost (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4611A206F5; Thu, 16 Jul 2020 06:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594880651; bh=Z/nrTcXcFk5J/58Hd9SKJQ2QPGf+Bc9TRddt07uYXJ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J1+Y5vDv98bZYgYKLHiON0mpd/bJAW/JRJIdHK5gRELyyKKz6ZDiJO0BDj9Ejrlvv KX36RQTyBVP96DWYJTp/OHW4rg6XkM0uK+fOJScU6N06KiSXEMrxtEUtO/oILiqfOn IVWiQoPGzHyRam56Su9cKc1ueWxKpPCrlEz6ZxRY= Date: Thu, 16 Jul 2020 11:54:06 +0530 From: Vinod Koul To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , Kishon Vijay Abraham I , Hans de Goede Subject: Re: linux-next: Tree for Jul 15 (drivers/phy/allwinner/phy-sun4i-usb.c) Message-ID: <20200716062406.GG55478@vkoul-mobl> References: <20200715180551.64d8d21e@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On 15-07-20, 08:18, Randy Dunlap wrote: > On 7/15/20 1:05 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20200714: > > > > on x86_64: > # CONFIG_GPIOLIB is not set > > ../drivers/phy/allwinner/phy-sun4i-usb.c: In function ‘sun4i_usb_phy0_get_id_det’: > ../drivers/phy/allwinner/phy-sun4i-usb.c:367:11: error: implicit declaration of function ‘gpiod_get_value_cansleep’; did you mean ‘gpio_get_value_cansleep’? [-Werror=implicit-function-declaration] > return gpiod_get_value_cansleep(data->id_det_gpio); > ^~~~~~~~~~~~~~~~~~~~~~~~ > gpio_get_value_cansleep > CC fs/bad_inode.o > ../drivers/phy/allwinner/phy-sun4i-usb.c: In function ‘sun4i_usb_phy_probe’: > ../drivers/phy/allwinner/phy-sun4i-usb.c:707:22: error: implicit declaration of function ‘devm_gpiod_get_optional’; did you mean ‘devm_clk_get_optional’? [-Werror=implicit-function-declaration] > data->id_det_gpio = devm_gpiod_get_optional(dev, "usb0_id_det", > ^~~~~~~~~~~~~~~~~~~~~~~ > devm_clk_get_optional > ../drivers/phy/allwinner/phy-sun4i-usb.c:708:11: error: ‘GPIOD_IN’ undeclared (first use in this function); did you mean ‘GPIOF_IN’? > GPIOD_IN); > ^~~~~~~~ > GPIOF_IN > ../drivers/phy/allwinner/phy-sun4i-usb.c:708:11: note: each undeclared identifier is reported only once for each function it appears in > ../drivers/phy/allwinner/phy-sun4i-usb.c:815:21: error: implicit declaration of function ‘gpiod_to_irq’; did you mean ‘gpio_to_irq’? [-Werror=implicit-function-declaration] > data->id_det_irq = gpiod_to_irq(data->id_det_gpio); > ^~~~~~~~~~~~ > gpio_to_irq > > > Full randconfig file is attached. Thanks Randy for the report, it is fixed by adding the right gpio header, sending a patch now -- ~Vinod