From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 100E9C433DF for ; Wed, 5 Aug 2020 20:07:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD45922CA1 for ; Wed, 5 Aug 2020 20:07:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aGfp0ca4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728973AbgHEUHF (ORCPT ); Wed, 5 Aug 2020 16:07:05 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:51062 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726835AbgHEQeG (ORCPT ); Wed, 5 Aug 2020 12:34:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596645214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Htm2JdguJ9wMbfUtNGIDXZzv/Zt05ES7M0m8GbVzmRI=; b=aGfp0ca41OmOEazrc8wUxqLUjb5p6Lsh/hIOwiaafTHLuTlxpxgI2WuNOC6j2wtRJVvxid 83kIx9NNoYz90pnDoTIhDykuIrNMf+IXqTY8ucNQpXHmwpM178X1O/Y1/CFbGqiKlOmBVM 7H0P3iDATDDPtASI4hVa0LqYHG3ZVA8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-432-bSMZvbQQPtmbHwA5KYU1wQ-1; Wed, 05 Aug 2020 09:06:35 -0400 X-MC-Unique: bSMZvbQQPtmbHwA5KYU1wQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BFAEB80183C; Wed, 5 Aug 2020 13:06:33 +0000 (UTC) Received: from localhost (unknown [10.36.110.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F7537B900; Wed, 5 Aug 2020 13:06:31 +0000 (UTC) Date: Wed, 5 Aug 2020 15:06:27 +0200 From: Stefano Brivio To: Stephen Rothwell , Cc: David Miller , Networking , Linux Next Mailing List , Linux Kernel Mailing List , Cong Wang Subject: Re: linux-next: build failure after merge of the net-next tree Message-ID: <20200805150627.3351fe24@redhat.com> In-Reply-To: <20200805223121.7dec86de@canb.auug.org.au> References: <20200805223121.7dec86de@canb.auug.org.au> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-next-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Wed, 5 Aug 2020 22:31:21 +1000 Stephen Rothwell wrote: > Hi all, > > After merging the net-next tree, today's linux-next build (s390 defconfig) > failed like this: > > net/ipv4/ip_tunnel_core.c:335:2: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration] > > Caused by commit > > 4cb47a8644cc ("tunnels: PMTU discovery support for directly bridged IP packets") Ouch, sorry for that. I'm getting a few of them by the way: --- net/core/skbuff.o: In function `skb_checksum_setup_ipv6': /home/sbrivio/net-next/net/core/skbuff.c:4980: undefined reference to `csum_ipv6_magic' net/core/netpoll.o: In function `netpoll_send_udp': /home/sbrivio/net-next/net/core/netpoll.c:419: undefined reference to `csum_ipv6_magic' net/netfilter/utils.o: In function `nf_ip6_checksum': /home/sbrivio/net-next/net/netfilter/utils.c:74: undefined reference to `csum_ipv6_magic' /home/sbrivio/net-next/net/netfilter/utils.c:84: undefined reference to `csum_ipv6_magic' net/netfilter/utils.o: In function `nf_ip6_checksum_partial': /home/sbrivio/net-next/net/netfilter/utils.c:112: undefined reference to `csum_ipv6_magic' net/ipv4/ip_tunnel_core.o:/home/sbrivio/net-next/net/ipv4/ip_tunnel_core.c:335: more undefined references to `csum_ipv6_magic' follow --- ...checking how it should be fixed now. Heiko, by the way, do we want to provide a s390 version similar to the existing csum_partial() implementation in arch/s390/include/asm/checksum.h right away? Otherwise, I'll just take care of the ifdeffery. -- Stefano